Extends support for CORS in CrudApiPlugin to action-level auth#1199
Merged
waldekmastykarz merged 1 commit intodotnet:mainfrom May 22, 2025
Merged
Extends support for CORS in CrudApiPlugin to action-level auth#1199waldekmastykarz merged 1 commit intodotnet:mainfrom
waldekmastykarz merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the CORS header logic in CrudApiPlugin to also recognize action-level Entra authentication.
- Adds a check for any action with
CrudApiAuthType.Entrabefore including theauthorizationheader in CORS responses.
Comments suppressed due to low confidence (2)
dev-proxy-plugins/Mocks/CrudApiPlugin.cs:220
- Add or update unit tests to cover the scenario where an action has
CrudApiAuthType.Entra, ensuring theaccess-control-allow-headersheader is correctly added.
if (_configuration.EntraAuthConfig is not null || _configuration.Actions.Any(a => a.Auth == CrudApiAuthType.Entra))
dev-proxy-plugins/Mocks/CrudApiPlugin.cs:222
- Potential NullReferenceException if
_configuration.Actionsis null. Consider using a null-conditional operator (e.g.,_configuration.Actions?.Any(...) == true) or ensureActionsis always initialized.
_configuration.Actions.Any(a => a.Auth == CrudApiAuthType.Entra)
garrytrinder
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.