Fixes issue with mocking#1198
Merged
waldekmastykarz merged 4 commits intodotnet:mainfrom May 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that each mock response is independently processed to prevent shared state across requests.
- Clone the matched
MockResponsebefore applying changes in the proxy plugin - Implement
ICloneableonMockResponseusing JSON serialization for deep copy
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dev-proxy-plugins/Mocks/MockResponsePlugin.cs | Clone matching mock response before calling ProcessMockResponseInternal to isolate per-request data |
| dev-proxy-abstractions/MockResponse.cs | Add ICloneable implementation to enable deep copy of MockResponse via JSON serialization |
Comments suppressed due to low confidence (1)
dev-proxy-plugins/Mocks/MockResponsePlugin.cs:183
- Consider adding a unit test that modifies a cloned response to verify it doesn't affect subsequent requests, ensuring the clone isolation works as intended.
ProcessMockResponseInternal(e, clonedResponse);
garrytrinder
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with mocking where updating the response in one request, would replace it for all subsequent requests as well.