Adds support for CORS for POST requests in CrudApiPlugin#1197
Merged
waldekmastykarz merged 3 commits intodotnet:mainfrom May 22, 2025
Merged
Adds support for CORS for POST requests in CrudApiPlugin#1197waldekmastykarz merged 3 commits intodotnet:mainfrom
waldekmastykarz merged 3 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for CORS for POST requests in the CrudApiPlugin by including content-type in the allowed headers when EntraAuthConfig is enabled.
- Expands the CORS
access-control-allow-headersvalue to includecontent-type - Applies change within the
AddCORSHeadersmethod under Mocks/CrudApiPlugin.cs
Comments suppressed due to low confidence (1)
dev-proxy-plugins/Mocks/CrudApiPlugin.cs:223
- Add or update unit tests to verify that the CORS response includes
content-typealongsideauthorizationwhenEntraAuthConfigis set, ensuring this change is covered and preventing future regressions.
headers.Add(new HttpHeader("access-control-allow-headers", "authorization, content-type"));
garrytrinder
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.