Reorders CLI options and subcommands to show alphabetically#1171
Merged
waldekmastykarz merged 5 commits intodotnet:mainfrom May 12, 2025
Merged
Reorders CLI options and subcommands to show alphabetically#1171waldekmastykarz merged 5 commits intodotnet:mainfrom
waldekmastykarz merged 5 commits intodotnet:mainfrom
Conversation
Collaborator
|
Thank you! We'll review it asap |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorders CLI commands and options alphabetically and integrates plugin-provided commands and options into the CLI.
- Updated ProxyHost to receive and sort plugin options and commands alphabetically.
- Adjusted the Program startup to pass streamlined plugin data.
- Added helper extension methods in CommandLineExtensions to support alphabetical ordering and simplified command/option additions.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dev-proxy/ProxyHost.cs | Modified root command creation to sort options/commands and include plugins. |
| dev-proxy/Program.cs | Refactored initialization to work with the new sorted plugin options and commands. |
| dev-proxy-abstractions/CommandLineExtensions.cs | Added extension methods for ordering and adding CLI components to commands. |
Comments suppressed due to low confidence (1)
dev-proxy/ProxyHost.cs:400
- [nitpick] The variable 'jwtCommand' is declared but never used, which may be confusing. Consider removing it if it is not needed.
var jwtCommand = new Command("jwt", "Manage JSON Web Tokens");
waldekmastykarz
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1075