Add support for embedding and processing embedded stacktrace line infos #7658
Conversation
Suchiman
force-pushed
the
EmbeddedStackTraceLineInfos
branch
from
79fb7cc to
0bcc735
Compare
src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/StackTraceMethodMappingNode.cs
Outdated
Show resolved
Hide resolved
src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/StackTraceMethodMappingNode.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| ObjectDataBuilder sequencePointsBuilder = new ObjectDataBuilder(factory, relocsOnly); | ||
| foreach (var mappingEntry in mappingEntries) |
There was a problem hiding this comment.
@jkotas do you have an opinion about potentially using the NativeLayout data structures for this? This appears different enough that I don't see a straightforward mapping, but NativeLayout does have the compressed integer capabilities that we're after.
There was a problem hiding this comment.
I have been looking around a bit and ofc 927 holds true, so i've found ObjectDataBuilder has this method which only appears to be used for EHInfo, System.Reflection.Metadata uses those for the PDB writing (only supporting signed values up to ~268 million) and BinaryWriter uses this simple one which would take up 5 bytes for negative numbers but one could shift the sign bit from msb to lsb to combat that.
There was a problem hiding this comment.
Yes, I think it would make sense to use https://github.com/dotnet/corert/tree/master/src/Common/src/Internal/NativeFormat for this.
Suchiman
force-pushed
the
EmbeddedStackTraceLineInfos
branch
2 times, most recently
from
c9132da to
a81f5da
Compare
Suchiman
force-pushed
the
EmbeddedStackTraceLineInfos
branch
from
a81f5da to
f503758
Compare
|
Closing stale PRs |
|
Sorry I didn't get back to this @Suchiman - I do think this is a very useful addition, but I also want to make sure that we can get the size on disk impact of this right:
I haven't had a chance to sit down and think how it would be best to achieve that. |
3 participants
As discussed @MichalStrehovsky
TODO:
Uncompressed numbers for sizes:
For a debug Hello World application (which includes debug information for corelib).