This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merged
Conversation
Contributor
Author
|
Do not merge this until RyuJit/OW are updated/published, which I will follow up including version number update here. |
kyulee1
force-pushed
the
cfi
branch
8 times, most recently
from
2c3e658 to
5fe6161
Compare
kyulee1
changed the title
Contributor
Author
|
We are now consuming new RyuJit/OW and I dropped [WIP]. |
Member
There was a problem hiding this comment.
This should be private constant in ObjectWriter I think.
Member
|
LGTM modulo comments. |
Contributor
Author
|
@jkotas Updated PR per feedbacks. The test failure is unrelated. |
Member
|
@kyulee1 Could you please resolve the conflicts so that it can be merged? |
This enables to emit unwind data for Unix. Unlike Windows UNWIND_INFO which has fully encoded binary, RyuJit passes a pseudo CFI_CODE[] table to CoreRT. This builds a map between offset and CFI_CODE blobs. Then when we emit code for a particular code offset, we also emit each CFI_CODE to ObjectWriter which will inject CFI directive accordingly. Then the backend of LLVM layouts eh_frame section per platform. Some of refactoring with regard to nodename is made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables to emit unwind data for Unix.
Unlike Windows UNWIND_INFO which has fully encoded binary,
RyuJit passes a pseudo CFI_CODE[] table to CoreRT.
This builds a map between offset and CFI_CODE blobs.
Then when we emit code for a particular code offset, we also
emit each CFI_CODE to ObjectWriter which will inject CFI
directive accordingly. Then the backend of LLVM layouts
eh_frame section per platform.
Some of refactoring with regard to nodename is made.