[armel tizen] Fixed issue #4626 unwinding support on arm#5249
[armel tizen] Fixed issue #4626 unwinding support on arm#5249jkotas merged 5 commits intodotnet:masterfrom
Conversation
|
@dotnet/arm32-corert-contrib |
| } | ||
|
|
||
| public void EmitCFICodes(int offset) | ||
| public void EmitCFICodes(int offset, NodeFactory factory) |
There was a problem hiding this comment.
Target platform is available in the _targetPlatform instance variable. This parameter seems unnecessary.
| @@ -1,7 +1,7 @@ | |||
| diff --git a/include/llvm/MC/MCObjectStreamer.h b/include/llvm/MC/MCObjectStreamer.h | |||
There was a problem hiding this comment.
Why a and b were changed to i and w? Could you undo this changes?
There was a problem hiding this comment.
@alpencolt I got these diffs by the command git diff I'll look what I can do with this
| assert((procInfo.start_ip <= controlPC) && (controlPC < procInfo.end_ip)); | ||
|
|
||
| #if defined(_ARM_) | ||
| *lsda = *((UIntNative *)procInfo.lsda); |
There was a problem hiding this comment.
Please add comment about why there is difference.
| { | ||
| EmitCFIStart(offset); | ||
| if (forArm) | ||
| EmitFnStart(_nativeObjectWriter); |
There was a problem hiding this comment.
Can this be just EmitFnStart() ?
| { | ||
| EmitCFIEnd(offset); | ||
| if (forArm) | ||
| EmitFnEnd(_nativeObjectWriter); |
src/Native/ObjWriter/objwriter.cpp
Outdated
| } | ||
|
|
||
| void | ||
| ObjectWriter::EmitFnStart() { |
There was a problem hiding this comment.
Should this be called EmiARMtFnStart ? It seems to be ARM specific looking at the implementation.
|
@alpencolt Does this look good to you? |
|
@jkotas yes |
|
Thank you! |
4 participants
This fix needs additional changes in CoreCLR that will be represented after this PR is approved. It fixed #4626, but there is another fail that is needed additional investigation.