This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Find unwind info ourselves instead of initializing unwind cursors each time.#5076
Merged
janvorli merged 1 commit intodotnet:masterfrom Dec 8, 2017
Merged
Conversation
Member
Author
|
@sergign60 As mentioned above, this will need some attention on ARM before it starts to work. I don't have access to ARM hardware, so I'm hoping someone who's actively working on ARM is able to take a look. It looks like you're the last person to do ARM-related changes in this code so I'm notifying you, but feel free to redirect as appropriate. Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous, we were initializing a libunwind cursor, doing a step, and converting contexts back and forth each time
VirtualUnwindwas called. This change continues the progress we've made towards removing the various context conversions and unnecessary cursor initialization.@janvorli PTAL
Once CI is passing and any feedback is addressed, I'd like to ask the folks working on ARM to take a look and fill in the missing pieces to get this working on ARM too.