This repository was archived by the owner on Nov 1, 2020. It is now read-only.
[RyuJIT/ARM32] Support for CFI unwind info#4755
Merged
jkotas merged 3 commits intodotnet:masterfrom Oct 18, 2017
Merged
Conversation
Contributor
Author
Contributor
Author
|
@jkotas @Dmitri-Botcharnikov @BredPet @alpencolt please review |
Contributor
Author
jkotas
reviewed
Oct 18, 2017
src/Native/jitinterface/jithost.cpp
Outdated
|
|
||
| #include "dllexport.h" | ||
|
|
||
| #ifndef _TARGET_ARM_ |
Member
There was a problem hiding this comment.
This should rather be #ifdef _X86_
jkotas
approved these changes
Oct 18, 2017
| @@ -951,7 +951,9 @@ public static void EmitObject(string objectFilePath, IEnumerable<DependencyNode> | |||
| objectWriter.BuildSymbolDefinitionMap(node, nodeContents.DefinedSymbols); | |||
|
|
|||
| // The DWARF CFI unwind is implemented for AMD64 only. | |||
Member
There was a problem hiding this comment.
Looks like the comment is now obsolete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.