This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Thread class improvements #2867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support custom stack size (maxStackSize parameter). * OOM hardening for new thread starting. Throw ThreadStartException in case of failure. * Create a new thread suspended and set its priority before resuming it. * In HasFinishedExecution method handle the case when an external thread died and its Thread object was resurrected. * Add test cases for resurrected Thread objects and maxStackSize parameter. Also fix a couple of issues copied from CLR/CoreCLR code: * Better handle OS threads with intermediate priorities. * Obtain the actual thread priority from the OS instead of using the cached value.
|
@AntonLapounov, |
kouvel
approved these changes
Mar 2, 2017
Member
Author
|
Thank you, Sergiy and Kount! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread class improvements:
Also fix a couple of issues copied from CLR/CoreCLR code: