This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Disable multiple connect attempts per socket on Linux.#5790
Merged
Conversation
joshfree
changed the title
Contributor
Author
|
This should unblock #5472 also. |
Member
|
@ericeil, I think you might need to do this in two stages: first remove usage of the native method from the managed code, and then once we have a System.Net.Sockets package that contains the fix, subsequently remove the now dead code from the native shim. |
Member
|
LGTM |
Contributor
|
LGTM as well. |
…appear to work correctly. Fixes #5754
…oes not appear to work correctly. Fixes #5754" We need to check in the managed code changes first. The native changes can come later, after we have a new build of System.Net.Sockets that doesn't depend on them. This reverts commit f1914d5.
…appear to work correctly. Fixes #5754
stephentoub
added a commit
that referenced
this pull request
Feb 1, 2016
Disable multiple connect attempts per socket on Linux.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Disable multiple connect attempts per socket on Linux. Commit migrated from dotnet/corefx@216da81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux implementation of multiple connect attempts per socket does not work correctly, per #5754. This change disables multiple connect attempts on all Unix platforms (since Linux was the only one that claimed to support it).
Fixes #5754
@pgavlin , @stephentoub