Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

System.Text.Json is not inbox on netfx #38077

Merged
wtgodbe merged 1 commit into from
May 31, 2019
Merged

System.Text.Json is not inbox on netfx #38077

wtgodbe merged 1 commit into from
May 31, 2019

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 30, 2019 •
edited
Loading

Fixes test build break introduced by 1743e47

Serialization\Value.ReadTests.cs(225,58): error CS0117: 'BitConverter' does not contain a definition for 'SingleToInt32Bits' [D:\a\1\s\src\System.Text.Json\tests\System.Text.Json.Tests.csproj]

corefx/src/System.Text.Json/tests/Serialization/Value.ReadTests.cs

Lines 224 to 227 in 30ca411

// Verify sign is correct; SingleToInt32Bits not available on netfx.
Assert.Equal(0x00000000u, (uint)BitConverter.SingleToInt32Bits(JsonSerializer.Parse<float>("0")));
Assert.Equal(0x80000000u, (uint)BitConverter.SingleToInt32Bits(JsonSerializer.Parse<float>("-0")));
Assert.Equal(0x80000000u, (uint)BitConverter.SingleToInt32Bits(JsonSerializer.Parse<float>("-0.0")));

These tests were failing on netfx, since System.Text.Json isn't inbox on that platform, but the ifdef wasn't catching that after we added netfx to the test configurations: https://github.com/dotnet/corefx/blame/master/src/System.Text.Json/tests/Configurations.props

CC @safern @ViktorHofer @ahsonkhan

@wtgodbe wtgodbe mentioned this pull request May 30, 2019
Merged
@wtgodbe
Copy link
Member Author

wtgodbe commented May 30, 2019

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 30, 2019

Azure Pipelines successfully started running 3 pipeline(s), but failed to run 1 pipeline(s).

ViktorHofer
ViktorHofer approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JeremyKuhne JeremyKuhne mentioned this pull request May 30, 2019
Merged
@ahsonkhan ahsonkhan added this to the 3.0 milestone May 31, 2019
@wtgodbe
Copy link
Member Author

wtgodbe commented May 31, 2019

Test failures are either known outerloop issues, or known infra failures on MUSL.

@wtgodbe wtgodbe merged commit 40983e2 into dotnet:master May 31, 2019
@ViktorHofer
Copy link
Member

ViktorHofer commented May 31, 2019

@wtgodbe please use azp run only when you want to trigger Outerloop. In this case I guess you just wanted to retrigger CI which you can do by either push force your amended commit or retrigger via the AzDO checks page.

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@wtgodbe
System.Text.Json is not inbox on netfx (dotnet/corefx#38077)
9ba1b9d 
Commit migrated from dotnet/corefx@40983e2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@ahsonkhan ahsonkhan ahsonkhan approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@safern safern safern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Text.Json

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wtgodbe @ViktorHofer @ahsonkhan @safern