This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enable interactive internal tools authentication#36560
Merged
ViktorHofer merged 3 commits intodotnet:masterfrom Apr 4, 2019
Merged
Enable interactive internal tools authentication#36560ViktorHofer merged 3 commits intodotnet:masterfrom
ViktorHofer merged 3 commits intodotnet:masterfrom
Conversation
Member
Author
|
@tmat should we bring this functionality into arcade in case other repositories also require internal tools locally for dev scenarios? |
ViktorHofer
changed the title
ViktorHofer
force-pushed
the
OptionalTools
branch
from
a0d5ef3 to
d6fc10e
Compare
tmat
reviewed
Apr 3, 2019
safern
reviewed
Apr 4, 2019
safern
approved these changes
Apr 4, 2019
Member
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
I don't like the duplication of the ToolsDir -> $(RepoRoot)\.tools -- I saw your comment that we should expose it in arcade, +1 on that.
Member
|
I think you have to ammend the commit and just push it, don't know what got screwed up. |
Member
Author
|
That has been happening the whole day already :D Usually reopening and retrying in AzDO helps. |
ViktorHofer
force-pushed
the
OptionalTools
branch
from
2fc6bb7 to
458e521
Compare
Member
Author
|
Seems not to work. I'll try your suggestion. |
Member
Author
|
/azp run corefx-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Merging as none of this code is executed in CI (and it succeeded before). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement interactive authentication for internal tools: NuGet/Home#7812 (comment)
Tested locally on Windows and Ubuntu (WSL) and both work fine. The authentication needs to be completed in 90sec otherwise it will fail.
Also created microsoft/artifacts-credprovider#85 to submit a minor bug in the shell script.