This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Don't Sleep(1) in some spin-wait loops (Fx) #34288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fx counterpart to dotnet/coreclr#21722
Author
|
@dotnet-bot test Windows x64 Debug Build |
stephentoub
reviewed
Dec 31, 2018
| do | ||
| { | ||
| spin.SpinOnce(); | ||
| spin.SpinOnce(sleep1Threshold: -1); |
Member
There was a problem hiding this comment.
I'm a little surprised the SpinOnce call here is valuable. This is one of the ones you tried removing and saw a regression as a result?
Author
There was a problem hiding this comment.
Yea I tried removing this one and the one in Pop, simplifying the one in pop to remove the extra backoff, so far those things didn't pan out, even the extra backoff in Pop seems to be (marginally) better than just one SpinOnce(sleep1Threshold: -1).
stephentoub
approved these changes
Dec 31, 2018
Author
|
@dotnet-bot test Linux arm64 Release Build |
1 similar comment
Author
|
@dotnet-bot test Linux arm64 Release Build |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fx counterpart to dotnet/coreclr#21722 Commit migrated from dotnet/corefx@4b6cc4f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fx counterpart to dotnet/coreclr#21722