Merge relevant changes from the auto-generated System.Runtime ref by ahsonkhan · Pull Request #33512 · dotnet/corefx

ahsonkhan · 2018-11-15T01:05:02Z

Though documentation on updating the System.Runtime ref is a bit lacking, the steps I followed might help others (in particular for System.Runtime):

Build coreclr release.
Build corefx release with coreclr bits (see link below for details).
Run msbuild /t:GenerateReferenceSource /p:ConfigurationGroup=Release from the System.Runtime/ref directory.
Filter out all unrelated changes and extract the changes you care about (ignore certain attributes being removed). Generally, this step is not required for other reference assemblies.

https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/developer-guide.md#testing-with-private-coreclr-bits

Added this documentation here: #33515

ahsonkhan · 2018-11-15T01:06:00Z

src/System.Runtime/ref/System.Runtime.cs

        void System.Runtime.Serialization.ISerializable.GetObjectData(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
        public override string ToString() { throw null; }
        public string ToString(int startIndex, int length) { throw null; }
+        public partial struct ChunkEnumerator


From #29877

cc @vancem, please review for correctness

src/System.Runtime/ref/System.Runtime.cs

ahsonkhan · 2018-11-15T01:07:51Z

src/System.Runtime/ref/System.Runtime.cs

-        public bool RunContinuationsAsynchronously { get { throw null; } set { throw null; } }
-        public void SetException(System.Exception error) { throw null; }
-        public void SetResult(TResult result) { throw null; }
+        public bool RunContinuationsAsynchronously { get { throw null; } set { } }


From #33104

cc @stephentoub, please review for correctness

stephentoub · 2018-11-15T01:07:57Z

src/System.Runtime/ref/System.Runtime.cs

    }
    public delegate void AsyncCallback(System.IAsyncResult ar);
-    [System.AttributeUsageAttribute((System.AttributeTargets)(32767), Inherited=true, AllowMultiple=false)]
+    [System.AttributeUsageAttribute(System.AttributeTargets.All, Inherited=true, AllowMultiple=false)]


It's great to see these values fixed to be readable :)

Yep, definitely!

ahsonkhan · 2018-11-15T01:08:35Z

src/System.Runtime/ref/System.Runtime.cs

    public delegate void Action<in T1, in T2, in T3, in T4, in T5, in T6, in T7, in T8, in T9>(T1 arg1, T2 arg2, T3 arg3, T4 arg4, T5 arg5, T6 arg6, T7 arg7, T8 arg8, T9 arg9);
    public static partial class Activator
    {
+        public static System.Runtime.Remoting.ObjectHandle CreateInstance(string assemblyName, string typeName) { throw null; }


From #30809

cc @MarcoRossignoli, please review for correctness

too late for me...but seems ok...one curiosity, it works also for new ref project?I mean if we create an empty file and run tool...for issue like https://github.com/dotnet/corefx/issues/33117

Good question!

If the file doesn't exist, then the tool throws an exception (can't find the expected file). We can probably fix it to create the ref file or at least fail gracefully.

Unhandled Exception: System.IO.DirectoryNotFoundException: Could not find a part of the path 'E:\GitHub\Fork\corefx\src\System.Json\ref\System.Json.cs'. at System.IO.FileStream.ValidateFileHandle(SafeFileHandle fileHandle) at System.IO.FileStream.CreateFileOpenHandle(FileMode mode, FileShare share, FileOptions options) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize) at System.IO.StreamWriter..ctor(String path, Boolean append) at System.IO.File.CreateText(String path) at GenAPI.Program.Main(String[] args)

cc @weshaggard

If, however, we create an empty file first in the correct folder (ref directory), then yes, it would work.

I just tried it with System.Json and it worked great. We just have to make sure to add back Obsolete or EditorBrowsableNever attributes that might exist in the source (fyi, System.Json doesn't have such attributes so the generated ref should be correct).

cc @danmosemsft

stephentoub · 2018-11-15T01:09:43Z

src/System.Runtime/ref/System.Runtime.cs

        public override int Read(System.Span<byte> buffer) { throw null; }
        public override System.Threading.Tasks.Task<int> ReadAsync(byte[] buffer, int offset, int count, System.Threading.CancellationToken cancellationToken) { throw null; }
-        public override System.Threading.Tasks.ValueTask<int> ReadAsync(System.Memory<byte> buffer, System.Threading.CancellationToken cancellationToken = default) { throw null; }
+        public override System.Threading.Tasks.ValueTask<int> ReadAsync(System.Memory<byte> buffer, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }


It'd be nice if the tool didn't require expanding this, but I realize that's how it's currently implemented.

Yep. We should fix it. dotnet/arcade#1341

src/System.Runtime/ref/System.Runtime.cs

ahsonkhan · 2018-11-15T01:10:47Z

src/System.Runtime/ref/System.Runtime.cs

        public static System.String Format(System.String format, params object[] args) { throw null; }
        public System.CharEnumerator GetEnumerator() { throw null; }
        public override int GetHashCode() { throw null; }
+        public static int GetHashCode(System.ReadOnlySpan<char> value) { throw null; }


From #33316

cc @GrabYourPitchforks, please review for correctness

ahsonkhan · 2018-11-15T01:19:12Z

src/System.Runtime/ref/System.Runtime.cs

        public virtual void Unlock(long position, long length) { }
        public override void Write(byte[] array, int offset, int count) { }
-        public override void Write(System.ReadOnlySpan<byte> buffer) { throw null; }
+        public override void Write(System.ReadOnlySpan<byte> buffer) { }


void returning methods don't need a method body, if anyone was wondering

ahsonkhan · 2018-11-15T01:19:51Z

src/System.Runtime/ref/System.Runtime.cs

-        public bool RunContinuationsAsynchronously { get { throw null; } set { throw null; } }
-        public void SetException(System.Exception error) { throw null; }
-        public void SetResult(TResult result) { throw null; }
+        public bool RunContinuationsAsynchronously { get { throw null; } set { } }


set doesn't need a method body, if anyone was wondering

…tnet#33512) * Merge relevant changes from the auto-generated System.Runtime ref * Update attributes and default enum values * Add back accidentally removed EditorBrowsableState attribute

…tnet/corefx#33512) * Merge relevant changes from the auto-generated System.Runtime ref * Update attributes and default enum values * Add back accidentally removed EditorBrowsableState attribute Commit migrated from dotnet/corefx@a624719

ahsonkhan added 2 commits November 14, 2018 16:42

Merge relevant changes from the auto-generated System.Runtime ref

ae0a9f7

Update attributes and default enum values

09766b5

ahsonkhan added the area-System.Runtime label Nov 15, 2018

ahsonkhan self-assigned this Nov 15, 2018

ahsonkhan requested review from GrabYourPitchforks, stephentoub, tarekgh and vancem November 15, 2018 01:05

ahsonkhan mentioned this pull request Nov 15, 2018

System.Text.Rune ref APIs and unit tests #33395

Merged

ahsonkhan commented Nov 15, 2018

View reviewed changes

src/System.Runtime/ref/System.Runtime.cs Show resolved Hide resolved

ahsonkhan commented Nov 15, 2018

View reviewed changes

stephentoub reviewed Nov 15, 2018

View reviewed changes

ahsonkhan commented Nov 15, 2018

View reviewed changes

stephentoub reviewed Nov 15, 2018

View reviewed changes

src/System.Runtime/ref/System.Runtime.cs Show resolved Hide resolved

ahsonkhan commented Nov 15, 2018

View reviewed changes

stephentoub approved these changes Nov 15, 2018

View reviewed changes

ahsonkhan mentioned this pull request Nov 15, 2018

The GenerateReferenceSource tool shouldn't expand out default args in the ref dotnet/arcade#1341

Open

Add back accidentally removed EditorBrowsableState attribute

f01736a

ahsonkhan requested a review from weshaggard November 15, 2018 01:17

ahsonkhan commented Nov 15, 2018

View reviewed changes

ahsonkhan merged commit a624719 into dotnet:master Nov 15, 2018

ahsonkhan deleted the FixSystemRuntimeRef branch November 15, 2018 04:54

karelz added this to the 3.0 milestone Nov 15, 2018

Conversation

ahsonkhan commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarcoRossignoli Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahsonkhan Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ahsonkhan commented Nov 15, 2018 •

edited

Loading

MarcoRossignoli Nov 15, 2018 •

edited

Loading

ahsonkhan Nov 15, 2018 •

edited

Loading