This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Revert "Add more VB operator tests" #32439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7c745fb.
ViktorHofer
force-pushed
the
revert-31320-more-vb-tests
branch
from
cde4cc9 to
858244e
Compare
Member
Author
|
cc @hughbe can you please resubmit your PR and fix the failures? |
Member
Author
|
probably related to dotnet/coreclr#19775 and dotnet/coreclr#20080 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…efx#32439) This reverts commit dotnet/corefx@7c745fb. Commit migrated from dotnet/corefx@5d3db03
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #31320
https://mc.dot.net/#/user/dotnet-maestro-bot/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/337c762a6133c4a5c835778df7d2077a21230dd6/workItem/Microsoft.VisualBasic.Tests
Could also be a separate issue (i.e. coreclr update) but the commit that went into master 2h ago that changed code pieces in Microsoft.VisualBasic is a strong indication. CI will show.
@danmosemsft next time when you merge a PR please make sure that the test legs were invoked recently. In this case the last run happened 22 days ago.