This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix creating subdirectories under directories with trailing separator…#30367
Merged
JeremyKuhne merged 1 commit intodotnet:release/2.1from Jun 27, 2018
Merged
Fix creating subdirectories under directories with trailing separator…#30367JeremyKuhne merged 1 commit intodotnet:release/2.1from
JeremyKuhne merged 1 commit intodotnet:release/2.1from
Conversation
dotnet#30293) * Fix creating subdirectories under directories with trailing separators This broke with dotnet#27810. Reworked the logic in an attempt to be clearer and added test cases. This addresses #30283. * Flip the logic to make it a little easier to follow. (Reduces the number of nots.) * Skip new test on desktop
JeremyKuhne
added
area-System.IO
Servicing-consider
pjanotti
approved these changes
Jun 13, 2018
Member
Author
|
@dotnet-bot test OSX x64 Debug Build |
danmoseley
removed
the
Servicing-consider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ports PR #30293, which fixes #30283.
This broke with #27810. Reworked the logic in an attempt to be clearer and added test cases.
This addresses #30283.
Flip the logic to make it a little easier to follow.
(Reduces the number of nots.)
Skip new test on desktop