Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Jun 11, 2018

Addresses #30249

@ianhays, FYI

@stephentoub
Copy link
Member

Does removing this really help us? It's very little code, and when we want to update brotli in the future, the easiest/safest thing would be just copying everything from the updated version, at which point these will be recreated, or each time we'll need to exert additional effort to keep them out. Seems better to me just to keep everything intact, even if a few pieces are unused.

@ghost
Copy link
Author

ghost commented Jun 12, 2018

Sounds reasonable. One important file that was removed after @dotnet-bot's original mirror commit was CMakeLists.txt. That is used by the fuzz script and the tool. Should that file be kept intact as well next time in the same spirit?

@stephentoub
Copy link
Member

Presumably it was removed to prevent them from being built? If so, that seems like a good reason to diverge for that file.

@ianhays
Copy link
Contributor

ianhays commented Jun 12, 2018

As stephen mentioned, we can remove this without any negative impact now, but a future update will likely undo the work. So it doesn't much matter either way.

@ghost
Copy link
Author

ghost commented Jun 12, 2018

Ok, I will keep an eye on progress on Google's side.

@ghost ghost closed this Jun 12, 2018
@ghost ghost deleted the cpp-toc-brotli branch June 12, 2018 17:25
@karelz karelz added this to the 3.0 milestone Jul 8, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants