This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix BeginConnect_EndPoint_AddressFamily_Throws_NotSupported test for netfx#29484
Merged
stephentoub merged 2 commits intodotnet:masterfrom May 3, 2018
Merged
Fix BeginConnect_EndPoint_AddressFamily_Throws_NotSupported test for netfx#29484stephentoub merged 2 commits intodotnet:masterfrom
stephentoub merged 2 commits intodotnet:masterfrom
Conversation
…netfx The test fails on .NET 4.7.2 due to trying to use the same Socket instance for a connection attempt after invalid arguments were passed to a previous attempt. Since that's not what this test is about, I'm just fixing it to avoid reusing the same Socket instance.
davidsh
reviewed
May 3, 2018
| new DnsEndPoint("localhost", 1, AddressFamily.InterNetworkV6), TheAsyncCallback, null)); | ||
| Assert.Throws<NotSupportedException>(() => { GetSocket(AddressFamily.InterNetwork).ConnectAsync( | ||
| new DnsEndPoint("localhost", 1, AddressFamily.InterNetworkV6)); }); | ||
| // Unlike other tests that reuse a static Socket instance, this tests avoids doing so |
Contributor
There was a problem hiding this comment.
nit: "this tests avoids doing so" -> "this test avoids doing so"
davidsh
approved these changes
May 3, 2018
Contributor
davidsh
left a comment
davidsh
left a comment
There was a problem hiding this comment.
Left a comment but otherwise LGTM.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…netfx (dotnet/corefx#29484) * Fix BeginConnect_EndPoint_AddressFamily_Throws_NotSupported test for netfx The test fails on .NET 4.7.2 due to trying to use the same Socket instance for a connection attempt after invalid arguments were passed to a previous attempt. Since that's not what this test is about, I'm just fixing it to avoid reusing the same Socket instance. * Fix comment typo Commit migrated from dotnet/corefx@c69beb4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test fails on .NET 4.7.2 due to trying to use the same Socket instance for a connection attempt after invalid arguments were passed to a previous attempt. Since that's not what this test is about, I'm just fixing it to avoid reusing the same Socket instance.
Fixes https://github.com/dotnet/corefx/issues/29481
Contributes to #29456
cc: @davidsh, @Caesar1995