Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update Windows.10.Amd64.ClientRS*.Open to use RS4 rather than RS2#29456

Merged
stephentoub merged 3 commits intomasterfrom
updaters4
May 3, 2018
Merged

Update Windows.10.Amd64.ClientRS*.Open to use RS4 rather than RS2#29456
stephentoub merged 3 commits intomasterfrom
updaters4

Conversation

@stephentoub
Copy link
Member

cc: @jcagme, @danmosemsft

@stephentoub
Copy link
Member Author

@dotnet-bot test ci please

@stephentoub
Copy link
Member Author

@jcagme, is there a way to verify this works as part of the PR?

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this.

@danmoseley
Copy link
Member

Do you want to change Windows.10.Amd64.ClientRS3.ES.Open higher up in the file also?

targetHelixQueues = ['Windows.7.Amd64.Open',
'Windows.81.Amd64.Open',
'Windows.10.Amd64.ClientRS3.ES.Open',]
'Windows.10.Amd64.ClientRS4.ES.Open',]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RS4 we don't have an ES image. If you need an Spanish image we'll have to stick with RS3 for now and start working in an RS4.ES. If ES is not a requirement please just use 'Windows.10.Amd64.ClientRS4.Open'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES is a requirement. I suggest we move to RS3 and yes it would be great to create an RS4.ES. Shall I open a core-eng issue JC?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please. Go ahead an open it and I'll make sure this is taken care of.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done thanks

@stephentoub stephentoub self-assigned this May 2, 2018
@stephentoub
Copy link
Member Author

@dotnet-bot test NETFX x86 Release Build please (checking to see if failures are deterministic)

@stephentoub
Copy link
Member Author

@dotnet-bot test Outerloop NETFX x86 Debug Build please

@stephentoub
Copy link
Member Author

@dotnet-bot test NETFX x86 Release Build please (outerloop passed, but just double-checking)

@stephentoub stephentoub merged commit fe27f8f into master May 3, 2018
@stephentoub stephentoub deleted the updaters4 branch May 3, 2018 21:04
@karelz karelz added this to the 2.2.0 milestone May 5, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…tnet/corefx#29456)

* Update Windows.10.Amd64.ClientRS*.Open to use RS4 rather than RS2

* Move Windows.10.Amd64.ClientRS3.ES.Open to Windows.10.Amd64.ClientRS4.ES.Open

* Revert ClientRS3 to ClientRS4 change


Commit migrated from dotnet/corefx@fe27f8f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants