This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Collapse leftover AsSpan().Slice(...) into AsSpan(...) #29078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
commented
Apr 12, 2018
| if (skip > 0) | ||
| { | ||
| sb.Append(path.AsSpan().Slice(0, skip)); | ||
| sb.Append(path.AsSpan(0, skip)); |
Author
There was a problem hiding this comment.
FYI, @JeremyKuhne
This should get mirrored to coreclr. cc @Anipik
Member
|
Looks these changes happened after fixing #27330 |
Author
|
@dotnet-bot test NETFX x86 Release Build |
tarekgh
approved these changes
Apr 12, 2018
stephentoub
approved these changes
Apr 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover from https://github.com/dotnet/corefx/issues/27330
Mainly updating usage pattern in tests.
cc @tarekgh