Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Enable partially implemented Intel HW intrinsics ISAs - CoreFX part of changes#28377

Closed
4creators wants to merge 1 commit intodotnet:release/2.1from
dotnetrt:EnableHWISAs
Closed

Enable partially implemented Intel HW intrinsics ISAs - CoreFX part of changes#28377
4creators wants to merge 1 commit intodotnet:release/2.1from
dotnetrt:EnableHWISAs

Conversation

@4creators
Copy link
Contributor

@4creators 4creators commented Mar 22, 2018

No description provided.

@4creators
Copy link
Contributor Author

4creators commented Mar 22, 2018

CoreCLR part of changes is in PR dotnet/coreclr#17134

@4creators 4creators mentioned this pull request Mar 22, 2018
Closed
@4creators
Copy link
Contributor Author

4creators commented Mar 22, 2018

Failures are unrelated to this PR:

On Windows.10.Amd64.Open-x86 and Windows.10.Nano.Amd64.Open-x64 failing test is:

PreAuthenticate_FirstRequestNoHeader_SecondRequestVariousStatusCodes_ThirdRequestPreauthenticates(statusCode: ResetContent)

@4creators
Copy link
Contributor Author

4creators commented Mar 22, 2018

@CarolEidt @eerhardt @fiigii @tannergooding

PTAL - PR is ready for review. It is not dependent on any other PR, however, full change will require waiting for changes from CoreCLR to propagate. CI Job failures are unrelated - see comment above.

fiigii
fiigii reviewed Mar 23, 2018
View reviewed changes
src/System.Runtime.Intrinsics.Experimental/ref/System.Runtime.Intrinsics.cs
LeastSignificant = 0x00,
MostSignificant = 0x40,
}
public enum ResultsFlag : byte
Copy link
Contributor

@fiigii fiigii Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResultsFlag also can be removed.

Copy link
Contributor Author

@4creators 4creators Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will fix.

@eerhardt
Copy link
Member

eerhardt commented Mar 24, 2018

This change should be against master.

We will add these APIs back into master once master has moved off of 2.1 versioning. I'm told that the final integration from master into release/2.1 isn't that far off. So it will only be temporary that these APIs don't exist in master.

eerhardt
eerhardt suggested changes Mar 24, 2018
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good - but this needs to target master.

@4creators
Copy link
Contributor Author

4creators commented Mar 24, 2018

Closing as this PR has been replaced with #28443

@4creators 4creators closed this Mar 24, 2018
@4creators 4creators deleted the EnableHWISAs branch March 24, 2018 02:30
@karelz karelz added this to the 2.1.0 milestone Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@fiigii fiigii fiigii left review comments

@eerhardt eerhardt eerhardt requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@4creators @eerhardt @fiigii @karelz