This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Support trimmed paths in FileInfo#27809
Merged
Merged
Conversation
Some paths are not creatable in Windows without special syntax. Notably paths with trailing spaces and periods. As GetFullPath() (and GetFullPathName()) trim these we would lose the correct file name as we passed the path around. With the enumeration changes we now populate FileInfo correctly- this change allows the other methods to work when wrapped around such a path.
danmoseley
reviewed
Mar 7, 2018
| // | ||
| /// <summary> | ||
| /// Copies an existing file to a new file. | ||
| /// If <paramref name="overwrite"/> is false, and exception will be |
danmoseley
reviewed
Mar 7, 2018
| // | ||
| // Your application must have Delete permission to the target file. | ||
| // | ||
| // or a file that is memory mapped. |
danmoseley
reviewed
Mar 7, 2018
| } | ||
|
|
||
|
|
||
| // Tests if a file exists. The result is true if the file |
There was a problem hiding this comment.
If you feel like changing it, "if" -> "whether"
danmoseley
reviewed
Mar 7, 2018
| FileInfo[] files = directory.GetFiles(); | ||
| Assert.Equal(2, files.Length); | ||
|
|
||
| FileInfo destination = new FileInfo(Path.Join(directory.FullName, GetTestFilePath())); |
There was a problem hiding this comment.
Maybe add "DeleteTestFilePath" to FileCleanupTestBase? Dispose can call it.
Member
Author
There was a problem hiding this comment.
Not sure what you're suggesting here.
danmoseley
reviewed
Mar 7, 2018
| string fullPath = Path.GetFullPath(path); | ||
|
|
||
| FileSystem.DeleteFile(fullPath); | ||
| FileSystem.DeleteFile(Path.GetFullPath(path)); |
There was a problem hiding this comment.
Do we always call GetFullPath immediately on paths passed in to IO API? This is presumably in case current directory changes?
Member
Author
There was a problem hiding this comment.
Yes, we always call GetFullPath(). The current directory thing would impact things, and in some cases we need to know that the path is normalized. Historically I'm sure it was more about CAS and the preemptive checks we made in GFP than anything else.
danmoseley
approved these changes
Mar 7, 2018
Remove NotSupported and SecurityException from Exists as these are no longer thrown. Add a test fix I hadn't staged correctly.
Anipik
reviewed
Mar 7, 2018
| DirectoryInfo directory = Directory.CreateDirectory(GetTestFilePath()); | ||
| string fileOne = Path.Join(directory.FullName, "Trailing space "); | ||
| string fileTwo = Path.Join(directory.FullName, "Trailing period."); | ||
| File.Create(@"\\?\" + fileOne).Dispose(); |
Member
Author
There was a problem hiding this comment.
To close the file handle right away so it doesn't stay locked past this point.
Anipik
approved these changes
Mar 7, 2018
Member
Author
|
@dotnet-bot test NETFX x86 Release Build Appears to have hung up running System.Net.Http.Functional.Tests |
|
@dotnet-bot test NETFX x86 Release Build please (hang now fixed) |
caesar-chen
pushed a commit
to caesar-chen/corefx
that referenced
this pull request
Mar 8, 2018
* Support trimmed paths in FileInfo Some paths are not creatable in Windows without special syntax. Notably paths with trailing spaces and periods. As GetFullPath() (and GetFullPathName()) trim these we would lose the correct file name as we passed the path around. With the enumeration changes we now populate FileInfo correctly- this change allows the other methods to work when wrapped around such a path. * Tweak comments. Remove NotSupported and SecurityException from Exists as these are no longer thrown. Add a test fix I hadn't staged correctly.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Support trimmed paths in FileInfo Some paths are not creatable in Windows without special syntax. Notably paths with trailing spaces and periods. As GetFullPath() (and GetFullPathName()) trim these we would lose the correct file name as we passed the path around. With the enumeration changes we now populate FileInfo correctly- this change allows the other methods to work when wrapped around such a path. * Tweak comments. Remove NotSupported and SecurityException from Exists as these are no longer thrown. Add a test fix I hadn't staged correctly. Commit migrated from dotnet/corefx@41a2120
Merged
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some paths are not creatable in Windows without special syntax. Notably paths with trailing spaces and periods. As GetFullPath() (and GetFullPathName()) trim these we would lose the correct file name as we passed the path around. With the enumeration changes we now populate FileInfo correctly- this change allows the other methods to work when wrapped around such a path.
Also remove some CAS related comments.
cc: @jkotas, @Anipik, @danmosemsft, @pjanotti