Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Removing files since MemoryExtensions is in CoreLib now. #27489

Closed
ahsonkhan wants to merge 3 commits into from
Closed

Removing files since MemoryExtensions is in CoreLib now. #27489

ahsonkhan wants to merge 3 commits into from

Conversation

@ahsonkhan
Copy link

@ahsonkhan ahsonkhan commented Feb 27, 2018

Part of https://github.com/dotnet/corefx/issues/25182

Depends on dotnet/coreclr#16521 (and the subsequent mirror PR).

  • Removed duplicated files
  • Moved the internal Clear helper methods from SpanHelpers.Clear.cs to SpanHelpers.cs since it is a small enough file

cc @jkotas, @KrzysztofCwalina, @stephentoub

@ahsonkhan ahsonkhan added blocked Issue/PR is blocked on something - see comments area-System.Memory labels Feb 27, 2018
@ahsonkhan ahsonkhan self-assigned this Feb 27, 2018
@ahsonkhan ahsonkhan mentioned this pull request Feb 27, 2018
Merged
@joshfree joshfree removed the blocked Issue/PR is blocked on something - see comments label Feb 27, 2018
@joshfree
Copy link
Member

joshfree commented Feb 27, 2018

@dotnet-bot test this please

@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 27, 2018

We have to wait for #27515

@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 27, 2018

@dotnet-bot test this please

@joshfree
Copy link
Member

joshfree commented Feb 28, 2018 

14:29:16 Build FAILED.
14:29:16 
14:29:16 System\Buffers\StandardFormat.cs(106,95): error CS0103: The name 'MemoryExtensions' does not exist in the current context [D:\j\workspace\windows-TGrou---f8ac6754\src\System.Memory\src\System.Memory.csproj]
14:29:16 System\Number\Number.NumberBuffer.cs(43,40): error CS1061: 'Span<byte>' does not contain a definition for 'IndexOf' and no extension method 'IndexOf' accepting a first argument of type 'Span<byte>' could be found (are you missing a using directive or an assembly reference?) [D:\j\workspace\windows-TGrou---f8ac6754\src\System.Memory\src\System.Memory.csproj]
14:29:16 System\Buffers\BuffersExtensions.cs(21,41): error CS7036: There is no argument given that corresponds to the required formal parameter 'comparisonType' of 'Span.IndexOf(ReadOnlySpan<char>, ReadOnlySpan<char>, StringComparison)' [D:\j\workspace\windows-TGrou---f8ac6754\src\System.Memory\src\System.Memory.csproj]
14:29:16     0 Warning(s)
14:29:16     3 Error(s)

@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 28, 2018 •
edited
Loading

The current coreclr version that corefx points to doesn't have MemoryExtensions.

We need a newer one: #27530

@ahsonkhan ahsonkhan mentioned this pull request Feb 28, 2018
Merged
@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 28, 2018

Cherry-picked the changes into #27530

Closing the PR.

@ahsonkhan ahsonkhan closed this Feb 28, 2018
@ahsonkhan ahsonkhan deleted the MoveMemExtensions branch February 28, 2018 03:05
@karelz karelz added this to the 2.1.0 milestone Mar 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@ahsonkhan ahsonkhan

Labels

area-System.Memory

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ahsonkhan @joshfree @karelz