This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Rename string-slicing extension methods #27328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of https://github.com/dotnet/corefx/issues/26894 the api folks have approved renaming AsROSpan and AsROMemory on string instances to AsSpan and AsMemory (as the "readonly" is obvious given the read-only nature of the input.) This puts the renaming in effect. Basically a big search-replace commit.
ghost
added
the
ghost
requested a review
from |
|
||
| // Skip OpenSSL part, and get the version string of format x.y.z | ||
| if (!Version.TryParse(OpenSslVersionDescription().AsReadOnlySpan().Slice(OpenSSL.Length, 5), out s_opensslVersion)) | ||
| if (!Version.TryParse(OpenSslVersionDescription().AsSpan().Slice(OpenSSL.Length, 5), out s_opensslVersion)) |
Member
There was a problem hiding this comment.
This should use the new overload of AsSpan that takes two ints. I know that for now you want to just do the renames, but I assume you will then scrub all ".AsSpan().Slice(" occurrences, correct?
Author
There was a problem hiding this comment.
KrzysztofCwalina
approved these changes
Feb 21, 2018
ahsonkhan
reviewed
Feb 21, 2018
| { | ||
| string s = "Hello"; | ||
| ReadOnlySpan<char> span = s.AsReadOnlySpan(); | ||
| ReadOnlySpan<char> span = s.AsSpan(); |
There was a problem hiding this comment.
Should we rename the test file now that we don't have AsReadOnlySpan anymore?
Author
There was a problem hiding this comment.
It's only the string methods that were renamed. This file is testing all the AsROSpan variants.
|
How do you plan to roll out this change for coreclr and uwp? |
ahsonkhan
approved these changes
Feb 21, 2018
Author
|
Aside from making whatever patches are needed to get the mirror PR's in, that seems to fall under "implementation cleanup" rather than a feature thing. The important part is that the public-facing api has its proper name. I can open a separate issue for that if you prefer but it's secondary priority. |
stephentoub
approved these changes
Feb 21, 2018
JeremyKuhne
pushed a commit
to JeremyKuhne/corefx
that referenced
this pull request
Feb 21, 2018
* Rename string-slicing extension methods As part of https://github.com/dotnet/corefx/issues/26894 the api folks have approved renaming AsROSpan and AsROMemory on string instances to AsSpan and AsMemory (as the "readonly" is obvious given the read-only nature of the input.) This puts the renaming in effect. Basically a big search-replace commit. * Fix OpenSSL build break * I see this is going to be a treadmill
dotnet-bot
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Feb 23, 2018
* Rename string-slicing extension methods As part of https://github.com/dotnet/corefx/issues/26894 the api folks have approved renaming AsROSpan and AsROMemory on string instances to AsSpan and AsMemory (as the "readonly" is obvious given the read-only nature of the input.) This puts the renaming in effect. Basically a big search-replace commit. * Fix OpenSSL build break * I see this is going to be a treadmill Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
jkotas
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Feb 23, 2018
* Rename string-slicing extension methods As part of https://github.com/dotnet/corefx/issues/26894 the api folks have approved renaming AsROSpan and AsROMemory on string instances to AsSpan and AsMemory (as the "readonly" is obvious given the read-only nature of the input.) This puts the renaming in effect. Basically a big search-replace commit. * Fix OpenSSL build break * I see this is going to be a treadmill Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 23, 2018
* Rename string-slicing extension methods As part of https://github.com/dotnet/corefx/issues/26894 the api folks have approved renaming AsROSpan and AsROMemory on string instances to AsSpan and AsMemory (as the "readonly" is obvious given the read-only nature of the input.) This puts the renaming in effect. Basically a big search-replace commit. * Fix OpenSSL build break * I see this is going to be a treadmill Signed-off-by: dotnet-bot-corefx-mirror <[email protected]> Signed-off-by: dotnet-bot <[email protected]>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 23, 2018
* Rename string-slicing extension methods As part of https://github.com/dotnet/corefx/issues/26894 the api folks have approved renaming AsROSpan and AsROMemory on string instances to AsSpan and AsMemory (as the "readonly" is obvious given the read-only nature of the input.) This puts the renaming in effect. Basically a big search-replace commit. * Fix OpenSSL build break * I see this is going to be a treadmill Signed-off-by: dotnet-bot-corefx-mirror <[email protected]> Signed-off-by: dotnet-bot <[email protected]>
kbaladurin
pushed a commit
to kbaladurin/corert
that referenced
this pull request
Mar 15, 2018
* Rename string-slicing extension methods As part of https://github.com/dotnet/corefx/issues/26894 the api folks have approved renaming AsROSpan and AsROMemory on string instances to AsSpan and AsMemory (as the "readonly" is obvious given the read-only nature of the input.) This puts the renaming in effect. Basically a big search-replace commit. * Fix OpenSSL build break * I see this is going to be a treadmill Signed-off-by: dotnet-bot-corefx-mirror <[email protected]> Signed-off-by: dotnet-bot <[email protected]>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Rename string-slicing extension methods As part of https://github.com/dotnet/corefx/issues/26894 the api folks have approved renaming AsROSpan and AsROMemory on string instances to AsSpan and AsMemory (as the "readonly" is obvious given the read-only nature of the input.) This puts the renaming in effect. Basically a big search-replace commit. * Fix OpenSSL build break * I see this is going to be a treadmill Commit migrated from dotnet/corefx@3538128
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of
https://github.com/dotnet/corefx/issues/26894
the api folks have approved renaming AsROSpan and AsROMemory
on string instances to AsSpan and AsMemory (as the "readonly"
is obvious given the read-only nature of the input.)
This puts the renaming in effect. Basically a big search-replace
commit.