This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Test updates for https://github.com/dotnet/coreclr/pull/16447 #27270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
reviewed
Feb 20, 2018
| } | ||
|
|
||
| [Fact] | ||
| [ActiveIssue(27269)] |
Member
There was a problem hiding this comment.
#27269 seems to be they issue for this PR. Wrong number?
Member
Author
There was a problem hiding this comment.
That should be right. This is disabling the test. I'll change the issue to re-enable after corelib is consumed.
Anipik
reviewed
Feb 20, 2018
| // This is a valid path on Unix | ||
| action(); | ||
| } | ||
| Assert.Null(Path.GetDirectoryName(" ")); |
There was a problem hiding this comment.
We dont have a test for this "\r\n" on .net core
Member
Author
There was a problem hiding this comment.
Thanks for pointing it out. I'll be making several passes through the tests as we settle in the changes in CoreLib. Please feel free to create new tests where you see we're lacking as well. :)
stephentoub
approved these changes
Feb 20, 2018
maryamariyan
approved these changes
Feb 20, 2018
Add GetFileName tests for volume separators.
Member
Author
|
@dotnet-bot test Linux x64 Release Build |
Member
Author
|
@dotnet-bot test OSX x64 Debug Build Failed for same reason as Linux above. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Test updates for dotnet/coreclr#16447 * Move variant test to own method. Add GetFileName tests for volume separators. Commit migrated from dotnet/corefx@24334bf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates and disables tests, tracked by #27269. For Path change in CoreCLR: dotnet/coreclr#16447