Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25708-01, preview2-25707-02, preview2-25707-02, beta-25708-00, beta-25708-00, preview1-25707-01, respectively (master) #23784

dotnet-maestro-bot · 2017-09-04T13:30:00Z

No description provided.

stephentoub · 2017-09-05T14:30:53Z

@mikem8361, this is related to the issue I mentioned to you over email... the latest coreclr is failing some stack trace tests:

      System.Diagnostics.Tests.StackFrameTests.Ctor_FNeedFileInfo(fNeedFileInfo: True) [FAIL]
        Assert.Equal() Failure
        Expected: 0
        Actual:   7
        Stack Trace:
          D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Diagnostics.StackTrace\tests\StackFrameTests.cs(166,0): at System.Diagnostics.Tests.StackFrameTests.VerifyStackFrameSkipFrames(StackFrame stackFrame, Boolean isFileConstructor, Int32 skipFrames, MethodInfo expectedMethod, Boolean isCurrentFrame)
          D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Diagnostics.StackTrace\tests\StackFrameTests.cs(34,0): at System.Diagnostics.Tests.StackFrameTests.Ctor_FNeedFileInfo(Boolean fNeedFileInfo)
      System.Diagnostics.Tests.StackFrameTests.Ctor_FNeedFileInfo(fNeedFileInfo: False) [FAIL]
        Assert.Equal() Failure
        Expected: 0
        Actual:   7
        Stack Trace:
          D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Diagnostics.StackTrace\tests\StackFrameTests.cs(166,0): at System.Diagnostics.Tests.StackFrameTests.VerifyStackFrameSkipFrames(StackFrame stackFrame, Boolean isFileConstructor, Int32 skipFrames, MethodInfo expectedMethod, Boolean isCurrentFrame)
          D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Diagnostics.StackTrace\tests\StackFrameTests.cs(34,0): at System.Diagnostics.Tests.StackFrameTests.Ctor_FNeedFileInfo(Boolean fNeedFileInfo)
      System.Diagnostics.Tests.StackFrameTests.Ctor_SkipFrames_FNeedFileInfo(skipFrames: 0, fNeedFileInfo: True) [FAIL]
        Assert.Equal() Failure
        Expected: 0
        Actual:   8
        Stack Trace:
          D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Diagnostics.StackTrace\tests\StackFrameTests.cs(166,0): at System.Diagnostics.Tests.StackFrameTests.VerifyStackFrameSkipFrames(StackFrame stackFrame, Boolean isFileConstructor, Int32 skipFrames, MethodInfo expectedMethod, Boolean isCurrentFrame)
          D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Diagnostics.StackTrace\tests\StackFrameTests.cs(57,0): at System.Diagnostics.Tests.StackFrameTests.Ctor_SkipFrames_FNeedFileInfo(Int32 skipFrames, Boolean fNeedFileInfo)
      System.Diagnostics.Tests.StackFrameTests.Ctor_SkipFrames_FNeedFileInfo(skipFrames: 0, fNeedFileInfo: False) [FAIL]
        Assert.Equal() Failure
        Expected: 0
        Actual:   8
        Stack Trace:
          D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Diagnostics.StackTrace\tests\StackFrameTests.cs(166,0): at System.Diagnostics.Tests.StackFrameTests.VerifyStackFrameSkipFrames(StackFrame stackFrame, Boolean isFileConstructor, Int32 skipFrames, MethodInfo expectedMethod, Boolean isCurrentFrame)
          D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Diagnostics.StackTrace\tests\StackFrameTests.cs(57,0): at System.Diagnostics.Tests.StackFrameTests.Ctor_SkipFrames_FNeedFileInfo(Int32 skipFrames, Boolean fNeedFileInfo)

Is this behavior change by design? If it is, the tests will need to be fixed before / as part of this PR to bring in the latest runtime.

EDIT: I just noticed these failures are actually in the netfx build. Hmmm....

stephentoub · 2017-09-05T14:33:24Z

@kouvel, the threading tests all appear to be hanging... could this be related to your latest changes related to spinning or other things in coreclr?
https://ci3.dot.net/job/dotnet_corefx/job/master/job/windows-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/2955/

kouvel · 2017-09-05T16:51:06Z

Taking a look

kouvel · 2017-09-05T18:29:43Z

Yes the hangs in threading/concurrent tests are caused by my change, sorry about that. PR dotnet/coreclr#13766 fixes the hangs.

kouvel · 2017-09-05T21:54:30Z

dotnet/coreclr#13766 is merged now and the hangs should be fixed once a CoreCLR that includes the change is published

stephentoub · 2017-09-05T23:15:56Z

Thanks, @kouvel.

stephentoub · 2017-09-06T02:41:13Z

@dotnet-bot test Linux x64 Release Build please (seg faults on CentOS)

danmoseley · 2017-09-06T20:13:14Z

OSX segfault in System.Security.Cryptography.X509Certificates

TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/bin/tests/AnyOS.AnyCPU.Debug/archive/tests/netcoreapp/System.ValueTuple.Tests.zip...
  Traceback (most recent call last):
    File "/Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/tempHome/.dumpling/dumpling.py", line 1128, in <module>
  processing dump file /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/bin/tests/System.Security.Cryptography.X509Certificates.Tests/netcoreapp-OSX-Debug-x64/core.99431
  creating dumpling dump 36af96fc271dcaa04b5c25fd53d13eeee63c6d54
  uploading artifact 36af96fc271dcaa04b5c25fd53d13eeee63c6d54 core.99431

@bartonjs there is a dumpfile for this but I don't know whether you have been successful with Mac dumps from dumpling. It may need trying locally (or this could be sporadic/unrelated)

danmoseley · 2017-09-06T20:21:49Z

RedHat.73 segfault in System.Collections.Concurrent.Tests .. maybe the known issue
Redhat73 and centos segfaults in System.Net.Security.Tests
these are both unfamiliar to me.
see if it's stable:
@dotnet-bot test Linux x64 Release Build please
@dotnet-bot test OSX x64 Debug Build please

bartonjs · 2017-09-06T20:28:27Z

I don't know whether you have been successful with Mac dumps from dumpling

@danmosemsft I've not investigated any segfaults (that I can remember) since dumpling was working. Are there directions?

danmoseley · 2017-09-06T22:36:08Z

@bartonjs well, it turns out it's not working on OSX. Looking up the guid from the log, I get http://dumpling.azurewebsites.net/api/dumplings/archived/36af96fc271dcaa04b5c25fd53d13eeee63c6d54 which is empty...
I've begun an effort to fix this ... meanwhile, this is not actionable. It's apparently flaky as it's now gone away on rerun...

stephentoub · 2017-09-07T19:15:52Z

@dotnet-bot test this please

stephentoub · 2017-09-07T20:54:49Z

@dotnet-bot test Linux x64 Release Build please (a bunch of seg faults)

stephentoub · 2017-09-07T20:55:32Z

(@danmosemsft, the seg faults were in the same suites on some of the same distros you mentioned)

stephentoub · 2017-09-07T23:58:33Z

It failed the same two suites again with seg faults on the same OSes: RedHat, CentOS, and Fedora. @danmosemsft, worth having someone take a look?

…tandard to preview2-25708-01, preview2-25707-02, preview2-25707-02, beta-25708-00, beta-25708-00, preview1-25707-01, respectively

danmoseley · 2017-09-08T05:18:45Z

This time it was a nuget issue, and a seg fault in drawing (as seen elsewhere)

Let's see if we can narrow down tests/distro .. unfortunately the force pushes cause the run data to get blown away each time.

@dotnet-bot test this please

kouvel · 2017-09-08T16:04:52Z

Based on https://github.com/dotnet/coreclr/issues/13779, the seg faults may be due to my change as well :(, I'm fixing

…tandard to preview2-25708-01, preview2-25707-02, preview2-25707-02, beta-25708-00, beta-25708-00, preview1-25707-01, respectively (dotnet/corefx#23784) Commit migrated from dotnet/corefx@0237599

dnfclas added the cla-already-signed label Sep 4, 2017

dotnet-maestro-bot changed the title ~~Update CoreSetup, Standard to preview2-25701-01, preview1-25704-01, respectively (master)~~ Update CoreClr, CoreSetup, Standard to preview2-25705-02, preview2-25701-01, preview1-25705-01, respectively (master) Sep 5, 2017

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from f18be4e to d4125d1 Compare September 5, 2017 13:29

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from d4125d1 to 0fb1caa Compare September 5, 2017 17:20

kouvel mentioned this pull request Sep 5, 2017

Fix SemaphoreSlim throughput dotnet/coreclr#13766

Merged

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 0fb1caa to 4ea8617 Compare September 6, 2017 00:50

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 4ea8617 to cfb214a Compare September 6, 2017 01:48

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from cfb214a to 8040da0 Compare September 6, 2017 03:16

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 8040da0 to ea5c91c Compare September 6, 2017 13:02

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from ea5c91c to f12ae27 Compare September 6, 2017 13:33

karelz added the area-Infrastructure-libraries label Sep 6, 2017

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from f12ae27 to 7dc993b Compare September 7, 2017 00:50

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 7dc993b to 00110e3 Compare September 7, 2017 01:47

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 00110e3 to 6ad15af Compare September 7, 2017 05:17

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 6ad15af to f58980b Compare September 7, 2017 13:16

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch 2 times, most recently from 3ffaab9 to 7a5765b Compare September 7, 2017 13:31

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 7a5765b to a6004fa Compare September 8, 2017 00:45

Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, S…

d9bfacd

…tandard to preview2-25708-01, preview2-25707-02, preview2-25707-02, beta-25708-00, beta-25708-00, preview1-25707-01, respectively

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from a6004fa to d9bfacd Compare September 8, 2017 05:16

stephentoub merged commit 0237599 into dotnet:master Sep 8, 2017

stephentoub deleted the master-UpdateDependencies branch September 8, 2017 11:13

karelz added this to the 2.1.0 milestone Oct 11, 2017

Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25708-01, preview2-25707-02, preview2-25707-02, beta-25708-00, beta-25708-00, preview1-25707-01, respectively (master) #23784

Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25708-01, preview2-25707-02, preview2-25707-02, beta-25708-00, beta-25708-00, preview1-25707-01, respectively (master) #23784

Uh oh!

Conversation

dotnet-maestro-bot commented Sep 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephentoub commented Sep 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephentoub commented Sep 5, 2017

Uh oh!

kouvel commented Sep 5, 2017

Uh oh!

kouvel commented Sep 5, 2017

Uh oh!

kouvel commented Sep 5, 2017

Uh oh!

stephentoub commented Sep 5, 2017

Uh oh!

stephentoub commented Sep 6, 2017

Uh oh!

danmoseley commented Sep 6, 2017

Uh oh!

danmoseley commented Sep 6, 2017

Uh oh!

bartonjs commented Sep 6, 2017

Uh oh!

danmoseley commented Sep 6, 2017

Uh oh!

stephentoub commented Sep 7, 2017

Uh oh!

stephentoub commented Sep 7, 2017

Uh oh!

stephentoub commented Sep 7, 2017

Uh oh!

stephentoub commented Sep 7, 2017

Uh oh!

danmoseley commented Sep 8, 2017

Uh oh!

kouvel commented Sep 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dotnet-maestro-bot commented Sep 4, 2017 •

edited

Loading

stephentoub commented Sep 5, 2017 •

edited

Loading