Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Skip asserts in Http SSL test on macOS#22305

Merged
stephentoub merged 1 commit intodotnet:masterfrom
stephentoub:skip_ssl_test
Jul 18, 2017
Merged

Skip asserts in Http SSL test on macOS#22305
stephentoub merged 1 commit intodotnet:masterfrom
stephentoub:skip_ssl_test

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Jul 16, 2017 •
edited
Loading

@karelz karelz modified the milestone: 2.1.0 Jul 16, 2017
@mmitche
Copy link
Member

mmitche commented Jul 17, 2017

@dotnet-bot test Outerloop OSX x64 Debug Build
@dotnet-bot test Outerloop OSX x64 Release Build

@dotnet dotnet deleted a comment from stephentoub Jul 17, 2017
bartonjs
bartonjs reviewed Jul 17, 2017
View reviewed changes
src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.ServerCertificates.cs Outdated
flags == X509ChainStatusFlags.RevocationStatusUnknown;
if (!skipAssertsForMacOS)
{
Assert.True(errors == SslPolicyErrors.None, $"Expected {SslPolicyErrors.None}, got {errors} with chain status {flags}");
Copy link
Member

@bartonjs bartonjs Jul 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assert should be the only one you need to skip. The rest should hold.

Copy link
Member Author

@stephentoub stephentoub Jul 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@stephentoub
Copy link
Member Author

stephentoub commented Jul 17, 2017

@dotnet-bot test Outerloop OSX x64 Debug Build
@dotnet-bot test Outerloop OSX x64 Release Build

@stephentoub
Copy link
Member Author

stephentoub commented Jul 18, 2017

@dotnet/dnceng, a lot of OSX legs are failing on different PRs with errors like:

Error during cleanup: java.io.IOException: remote file operation failed: /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest at hudson.remoting.Channel@19413640:JNLP4-connect connection from 131.107.19.218/131.107.19.218:50077: hudson.remoting.ChannelClosedException: channel is already closed

@stephentoub
Copy link
Member Author

stephentoub commented Jul 18, 2017

@dotnet-bot test Outerloop OSX x64 Debug Build please
@dotnet-bot test OSX x64 Debug Build please

@stephentoub
Copy link
Member Author

stephentoub commented Jul 18, 2017

@dotnet-bot test Outerloop OSX x64 Debug Build please
@dotnet-bot test OSX x64 Debug Build please
@dotnet-bot test Outerloop OSX x64 Release Build

@stephentoub
Copy link
Member Author

stephentoub commented Jul 18, 2017

@dotnet/dnceng, @mmitche, the OSX legs are still failing even after Matt reset the boxes, e.g. "Using context: OSX x64 Debug Build
java.nio.channels.ClosedChannelException"

@mmitche
Copy link
Member

mmitche commented Jul 18, 2017

@dotnet-bot test OSX x64 Debug Build please

@mmitche
Copy link
Member

mmitche commented Jul 18, 2017

@stephentoub I think it actually might just be one of the machines.

@stephentoub
Copy link
Member Author

stephentoub commented Jul 18, 2017

I think it actually might just be one of the machines.

Ok, thanks. Can we take it out of the rotation until it's fixed?

@stephentoub stephentoub merged commit bb45594 into dotnet:master Jul 18, 2017
@stephentoub stephentoub deleted the skip_ssl_test branch July 18, 2017 15:42
@mmitche
Copy link
Member

mmitche commented Jul 18, 2017

@stephentoub Done. Can you let me know whether you see it again. @dotnet/dnceng for visibility

@stephentoub
Copy link
Member Author

stephentoub commented Jul 18, 2017

Can you let me know whether you see it again

Will do. Thanks.

pjanotti pushed a commit to pjanotti/corefx that referenced this pull request Jul 20, 2017
@stephentoub
Skip assert in Http SSL test on macOS (dotnet#22305)
da868b6
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@stephentoub
Skip assert in Http SSL test on macOS (dotnet/corefx#22305)
a162c38 
Commit migrated from dotnet/corefx@bb45594
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bartonjs bartonjs bartonjs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoub stephentoub

Labels

area-System.Net.Http

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@stephentoub @mmitche @bartonjs @karelz @dnfclas