This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove unnecessary calls to GetTypeInfo() in System.Linq.Expressions. #16311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-bot
pushed a commit
that referenced
this pull request
Feb 23, 2018
* Dial back aggressive checks in Path Aggressive checks are preventing crossplat and extended Windows solutions. This change: - Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot - Doesn't consider colon when looking at path segments on Windows - Moves non-shared code out of PathInternal - Fix span GetDirectoryName to handle multiple separators * Comment updates * Check for valid drive letter with PathRoot Remove other usages of PathSkip (related to #16311) Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
stephentoub
pushed a commit
that referenced
this pull request
Feb 23, 2018
* Dial back aggressive checks in Path Aggressive checks are preventing crossplat and extended Windows solutions. This change: - Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot - Doesn't consider colon when looking at path segments on Windows - Moves non-shared code out of PathInternal - Fix span GetDirectoryName to handle multiple separators * Comment updates * Check for valid drive letter with PathRoot Remove other usages of PathSkip (related to #16311) Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…dotnet/corefx#16311) * Remove GetTypeInfo() from IsValueType calls. * Remove GetTypeInfo from IsAssignableFrom calls * Remove GetTypeInfo() from IsSubclassOf calls * Remove GetTypeInfo() from IsGenericType calls * Remove GetTypeInfo() from IsInterface calls * Remove GetTypeInfo() from IsEnum calls * Remove GetTypeInfo from IsPrimitive and IsAbstract calls * Remove unnecessary calls to GetTypeInfo() Commit migrated from dotnet/corefx@720474a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #16305
I think it may be safe to replace
.GetTypeInfo().ImplementedInterfaceswith.GetInterfaces()but not being 100% certain I'm leaving that as is. That is now the only calls toGetTypeInfo()in the main project, though some remain in the test project.