This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Change ActiveIssue to PlatformSpecific for closed issue #5832. - #10308
Merged
Merged
Conversation
|
|
||
| [Fact] | ||
| [ActiveIssue(5832, PlatformID.AnyUnix)] | ||
| [PlatformSpecific(PlatformID.Windows)] // https://github.com/dotnet/corefx/issues/5832 |
Member
There was a problem hiding this comment.
The linked issue makes it sound like this isn't safe on Windows either, that it could result in AVs. Are these tests ok for Windows, or should they be deleted entirely?
Contributor
Author
There was a problem hiding this comment.
These have been running reliably on Windows so far, so I'm reluctant to throw away the coverage provided by these tests. If we start seeing issues on Windows, we should reconsider, but for now let's keep them.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.