This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Updating the new System.MathF calls which already existed in System.Math to call the System.Math implementation.#7721
Merged
janvorli merged 2 commits intodotnet:masterfrom Oct 19, 2016
tannergooding:math
Merged
Updating the new System.MathF calls which already existed in System.Math to call the System.Math implementation.#7721janvorli merged 2 commits intodotnet:masterfrom tannergooding:math
System.MathF calls which already existed in System.Math to call the System.Math implementation.#7721janvorli merged 2 commits intodotnet:masterfrom
tannergooding:math
Conversation
8 tasks
Member
|
Can you also remove the native implementations of those functions? |
Member
Author
|
Can do. |
Member
Author
|
I have removed the FCALL entry for
|
…m.Math` to call the `System.Math` implementation.
sergign60
pushed a commit
to sergign60/coreclr
that referenced
this pull request
Nov 14, 2016
…m.Math` to call the `System.Math` implementation. (dotnet#7721) * Updating the new `System.MathF` calls which already existed in `System.Math` to call the `System.Math` implementation. * Removing the FCALL entry for MathF.Abs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI. @janvorli