This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
Member
|
LGTM. Thanks! |
This was referenced Sep 7, 2016
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/coreclr@5c32341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThrowArgumentOutOfRangeExceptioninlined too much so changed to throw directly which stops it being inlined (and its inner Enums)ThrowArgumentOutOfRange_IndexExceptionso its clear what is out of range when called.IfNullAndNullsAreIllegalThenThrowas is above inline size; so its either entirely dropped for reference types; or reduced to the single non-inlined call for boxed value types.