This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Adding support for more generic dictionary entry slots for R2R - #6291
Merged
Merged
Conversation
Author
|
@JohnChen0 @jkotas PTAL |
|
|
||
| READYTORUN_FIXUP_DelegateCtor = 0x2C, /* optimized delegate ctor */ | ||
| READYTORUN_FIXUP_DeclaringTypeHandle = 0x2D, | ||
| }; |
Member
There was a problem hiding this comment.
Do we need to bump the version number as was discussed?
Member
|
Any interesting test cases that should be added to the R2R unit test to exercise this? |
Member
|
LGTM otherwise. |
Author
|
@jkotas I am planning to merge these changes after merging the FieldDescHandle changes, which include the version change (see other PR). |
fadimounir
force-pushed
the
methodhandle
branch
2 times, most recently
from
August 4, 2016 17:33
60ef4d5 to
27d8c01
Compare
DeclaringTypeHandleSlot ConstrainedMethodEntrySlot
fadimounir
force-pushed
the
methodhandle
branch
from
August 4, 2016 17:35
27d8c01 to
b864fd8
Compare
Author
|
@dotnet-bot test Windows_NT Checked pri1r2r please |
Author
|
@dotnet-bot test Ubuntu Checked pri1r2r please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…R: (dotnet/coreclr#6291) DeclaringTypeHandleSlot ConstrainedMethodEntrySlot Commit migrated from dotnet/coreclr@010f42a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support to the following generic dictionary entry slots for R2R:
DeclaringTypeHandleSlot
ConstrainedMethodEntrySlot