This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Named mutex: Use flock instead of pthread process-shared mutex in som…#6015
Merged
kouvel merged 1 commit intodotnet:masterfrom Jul 6, 2016
kouvel:NamedMutexMoreFlockCases
Merged
Named mutex: Use flock instead of pthread process-shared mutex in som…#6015kouvel merged 1 commit intodotnet:masterfrom kouvel:NamedMutexMoreFlockCases
kouvel merged 1 commit intodotnet:masterfrom
kouvel:NamedMutexMoreFlockCases
Conversation
Author
|
I've got a fix for the robust mutex bug in musl that's about to go upstream and which Alpine will hopefully be adopting soon. |
|
Link to commit fixing the bug in musl: https://git.musl-libc.org/cgit/musl/commit/?id=384d103d94dba0472a587861f67d7ed6e8955f86 |
Author
|
@dotnet-bot test this please |
1 similar comment
Author
|
@dotnet-bot test this please |
Author
Author
|
@dotnet-bot test this please |
Author
|
@janvorli & @adityamandaleeka, could one of you please take a look? |
| int result = DoTest(); | ||
| if (result < 0) | ||
| return 0; | ||
| return result >= 0 ? result : 0; |
Member
There was a problem hiding this comment.
Not important, but you could get rid of the check above since this does the same thing right?
Member
|
Left some minor comments. LGTM otherwise. |
…e more cases Workaround for #5456: - Sometimes, a timed wait operation is not getting released, causing a hang - Due to the hang, it is not possible to detect this issue with code - Temporarily disabled the use of pthread process-shared mutexes on ARM/ARM64. File locks will be used instead. Workaround for #5872: - On Alpine Linux, a pthread process-shared robust mutex is detecting the case where a process abandons the mutex when it exits while holding the lock, but is putting the mutex into an unrecoverable state (ENOTRECOVERABLE) instead of assigning lock ownership to the next thread that is released from a wait for a lock and notifying of abandonment (EOWNERDEAD). - Added a test case to detect this issue, to have it use file locks instead Close #5456
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/coreclr
that referenced
this pull request
Jun 26, 2018
Fixes #6016. Resolves dotnet#6015. Signed-off-by: dotnet-bot <[email protected]>
jkotas
pushed a commit
that referenced
this pull request
Jun 27, 2018
Fixes #6016. Resolves #6015. Signed-off-by: dotnet-bot <[email protected]>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…kCases Named mutex: Use flock instead of pthread process-shared mutex in som… Commit migrated from dotnet/coreclr@66b6219
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fixes dotnet/coreclr#6016. Resolves dotnet/coreclr#6015. Signed-off-by: dotnet-bot <[email protected]> Commit migrated from dotnet/coreclr@bcabe11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e more cases
Workaround for #5456:
Workaround for #5872:
Close #5456