This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Use cached tasks for Task.FromResult #5186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use cached tasks for both FromResult and AsyncTaskMethodBuilder rather than just AsyncTaskMethodBuilder Move GetTaskForResult from AsyncMethodBuilder to Task<TResult> Move AsyncTaskCache from AsyncMethodBuilder to future Call Task<TResult>.GetTaskForResult(result) from FromResult rather than creating new Task Call Task.FromResult<TResult>(result) from AsyncTaskMethodBuilder rather than GetTaskForResult(result)
Member
|
Fast on .NET Core, slow on .NET Framework? Or will be port this? Isn't this a breaking change at this point? |
Member
Author
|
Was design decision https://github.com/dotnet/coreclr/issues/5185#issuecomment-221330249 allocation vs indirection |
Member
Author
|
Likely a moot change anyway with arbitrary async returns dotnet/roslyn#10902 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cached tasks for both
Task.FromResultandAsyncTaskMethodBuilderrather than justAsyncTaskMethodBuilderGetTaskForResultfromAsyncMethodBuildertoTask<TResult>AsyncTaskCachefromAsyncMethodBuilderto future.csTask<TResult>.GetTaskForResult(result)fromFromResultrather than creating newTaskTask.FromResult<TResult>(result)fromAsyncTaskMethodBuilderrather thanGetTaskForResult(result)/cc @stephentoub
Resolves #5185