This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port fix for #1241 to 3.1 #27983
Merged
Port fix for #1241 to 3.1 #27983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this for 3.1.3? CC @jeffschwMSFT |
|
Please add code reviewer. It will be for 3.1.3. |
Author
|
@briansull @BruceForstall - you reviewed the original change, can you verify this port? |
jeffschwMSFT
added
the
Servicing-consider
Member
|
@wtgodbe yes we will seek 3.1.3 approval |
BruceForstall
approved these changes
Jan 17, 2020
jeffschwMSFT
added
Servicing-approved
Member
|
Approved for 3.1.3 (March) - need to wait for the branch to open before merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of dotnet/runtime#1279 to 3.1 branch.
This is the fix for dotnet/runtime#1241. This is a SBCG bug reported externally. When a struct is partially written, the JIT fails to invalidate assertions (in this case that the entire struct had been zero'd). This results in incorrect optimization. The fix is to invalidate the assertions in the partial write case.
Customer Impact
SBCG resulting in incorrect behavior.
Regression?
Not a recent regression, but exposed by doing more optimizations on structs.
Testing
The fix has been verified in the runtime repo.
Risk
Low: The fix is straightforward and kills assertions which only disables optimizations.
Code Reviewer
@briansull and @BruceForstall