This repository was archived by the owner on Jan 23, 2023. It is now read-only.
resolve several issues found by cppcheck #26869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
found by cppcheck [src/debug/daccess/nidump.cpp:2839] -> [src/debug/daccess/nidump.cpp:2841]: (warning) Opposite inner 'if' condition leads to a dead code block.
found by cppcheck [src/dlls/dbgshim/dbgshim.cpp:1373] -> [src/dlls/dbgshim/dbgshim.cpp:1367]: (warning) Either the condition 'pHandleArray==NULL' is redundant or there is pointer arithmetic with NULL pointer.
found by cppcheck [src/ilasm/assembler.cpp:2331] -> [src/ilasm/assembler.cpp:2330]: (warning) Either the condition 'pMID==NULL' is redundant or there is possible null pointer dereference: pMID.
found by cppcheck [src/jit/flowgraph.cpp:11009] -> [src/jit/flowgraph.cpp:11005]: (warning) Either the condition 'block!=nullptr' is redundant or there is possible null pointer dereference: block.
found by cppcheck [src/pal/src/debug/debug.cpp:376] -> [src/pal/src/debug/debug.cpp:381]: (warning) Either the condition 'command_string' is redundant or there is possible null pointer dereference: command_string.
…nter dereference found by cppcheck [src/pal/src/libunwind/src/arm/Gex_tables.c:159] -> [src/pal/src/libunwind/src/arm/Gex_tables.c:155]: (warning) Either the condition 'buf!=NULL' is redundant or there is pointer arithmetic with NULL pointer.
…dereference found by cppcheck [src/pal/src/synchmgr/synchmanager.cpp:2512] -> [src/pal/src/synchmgr/synchmanager.cpp:2510]: (warning) Either the condition 'NULL!=pWLNode' is redundant or there is possible null pointer dereference: pWLNode.
sandreenko
reviewed
Sep 24, 2019
|
|
||
| /* The block has to be either unreachable or empty */ | ||
|
|
||
| PREFIX_ASSUME(block != nullptr); |
There was a problem hiding this comment.
@janvorli Does it make sense to use PREFIX_ASSUME for null checks? I think in debug it is the same behavior as a regular assert and in release it can't give any valuable hint for the compiler, can it?
Member
There was a problem hiding this comment.
In release, it is expanded to __assume. In static analyzer builds, it expands to if (!(_condition)) __UNREACHABLE(); in all build configurations. So it seems it makes sense.
There was a problem hiding this comment.
I mean the release code for:
__assume(p != nullptr);
p->field;
and for
p->field;
would be the same.
Member
There was a problem hiding this comment.
I am not sure if I understand - the __assume is a hint to the compiler. Of course the generated code would be the same. So the PREFIX_ASSUME is basically an extended kind of assert that static analysis tools can understand even in release build.
sdmaclea
pushed a commit
to sdmaclea/libunwind
that referenced
this pull request
May 7, 2020
found by cppcheck [src/arm/Gex_tables.c:159] -> [src/arm/Gex_tables.c:155]: (warning) Either the condition 'buf!=NULL' is redundant or there is pointer arithmetic with NULL pointer. Upstreamed from dotnet/coreclr#26869
djwatson
pushed a commit
to libunwind/libunwind
that referenced
this pull request
May 18, 2020
found by cppcheck [src/arm/Gex_tables.c:159] -> [src/arm/Gex_tables.c:155]: (warning) Either the condition 'buf!=NULL' is redundant or there is pointer arithmetic with NULL pointer. Upstreamed from dotnet/coreclr#26869
eyudin
pushed a commit
to ndmsystems/libunwind
that referenced
this pull request
Mar 9, 2021
found by cppcheck [src/arm/Gex_tables.c:159] -> [src/arm/Gex_tables.c:155]: (warning) Either the condition 'buf!=NULL' is redundant or there is pointer arithmetic with NULL pointer. Upstreamed from dotnet/coreclr#26869
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.