This repository was archived by the owner on Jan 23, 2023. It is now read-only.
JIT: use stress mode tail call validation info for implicit tail calls#25093
Merged
AndyAyersMS merged 1 commit intodotnet:masterfrom Jun 12, 2019
Merged
Conversation
If a call site fails tail call stress validation, don't consider it for implicit tail calling either. In normal jitting we defer this level of validation until impImportCall to avoid duplicating work. This avoids an assert when we have invalid IL. Fixes #25027.
Member
Author
|
@BruceForstall PTAL There's a more detailed discussion of what was going wrong over in #25027. And some suggestions for revisiting all this tangled logic over in #25094. Depending on when #24962 lands, we may need to modify this PR or that one so the CoreFx tests that were hitting this are no longer excluded. No pmi diffs (as expected). |
BruceForstall
approved these changes
Jun 11, 2019
Member
Author
|
Looks like the CoreFx exclusion of |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
dotnet/coreclr#25093) If a call site fails tail call stress validation, don't consider it for implicit tail calling either. In normal jitting we defer this level of validation until impImportCall to avoid duplicating work. This avoids an assert when we have invalid IL. Fixes dotnet/coreclr#25027. Commit migrated from dotnet/coreclr@a12705b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a call site fails tail call stress validation, don't consider it for
implicit tail calling either.
In normal jitting we defer this level of validation until impImportCall
to avoid duplicating work.
This avoids an assert when we have invalid IL.
Fixes #25027.