This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Do not use /OPT:REF /OPT:ICF for static libraries#2310
Merged
jkotas merged 1 commit intodotnet:masterfrom Dec 11, 2015
Merged
Conversation
These options are only valid on dlls and exes and generate linker warnings when used on static libraries
Member
|
LGTM. Thanks! |
jkotas
added a commit
that referenced
this pull request
Dec 11, 2015
Do not use /OPT:REF /OPT:ICF for static libraries
mikedn
added a commit
to mikedn/coreclr
that referenced
this pull request
Jan 3, 2016
This was fixed in dotnet#2310 and the fix was accidentally reverted in dotnet#2244 and dotnet#2425
Merged
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Do not use /OPT:REF /OPT:ICF for static libraries Commit migrated from dotnet/coreclr@57f7b99
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This was fixed in dotnet/coreclr#2310 and the fix was accidentally reverted in dotnet/coreclr#2244 and dotnet/coreclr#2425 Commit migrated from dotnet/coreclr@3179786
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These options are only valid on dlls and exes and generate linker warnings when used on static libraries