Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Cleanup unused hosting interfaces - #23091

Merged
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:cleanup
Mar 7, 2019
Merged

jkotas merged 1 commit into
dotnet:masterfrom
jkotas:cleanup

Conversation

@jkotas

@jkotas jkotas commented Mar 7, 2019

Copy link
Copy Markdown
Member

No description provided.

//*****************************************************************************
// Signature utilities.
//*****************************************************************************
class MetaSigExport : public MetaSig

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy&paste from tlbexport.h

Comment thread src/inc/utilcode.h
HRESULT Utf2Quick(
LPCUTF8 pStr, // The string to convert.
CQuickArray<WCHAR> &rStr, // The QuickArray<WCHAR> to convert it into.
int iCurLen); // Inital characters in the array to leave (default 0).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inital -> Initial

@jkotas

jkotas commented Mar 7, 2019

Copy link
Copy Markdown
Member Author

The interfaces that I am deleting are either SQL hosting-specific, WindowsPhone-specific or not used at all.

@sdmaclea sdmaclea left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review. LGTM

@jkotas

jkotas commented Mar 7, 2019

Copy link
Copy Markdown
Member Author

@dotnet-bot test Ubuntu x64 Checked CoreFX Tests please

@jkotas
jkotas merged commit 70300c7 into dotnet:master Mar 7, 2019
@jkotas
jkotas deleted the cleanup branch March 7, 2019 16:31
@jkotas
jkotas restored the cleanup branch April 19, 2019 16:42
@jkotas
jkotas deleted the cleanup branch April 19, 2019 16:43
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants