This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Set flag in comp info to signal that a caller has >8 byte struct args#22775
Merged
jashook merged 5 commits intodotnet:masterfrom Feb 28, 2019
Merged
Set flag in comp info to signal that a caller has >8 byte struct args#22775jashook merged 5 commits intodotnet:masterfrom
jashook merged 5 commits intodotnet:masterfrom
Conversation
This will be used by fgCanFastTailCall to correctly determine whether an arm64 or x64 linux caller/callee can fastTailCall. It is also a workaround to #12468 to catch early any slot shuffling that would happen in LowerFastTailCall. Which currently assumes all parameters are one slot size.
Author
|
/cc @dotnet/jit-contrib |
CarolEidt
approved these changes
Feb 22, 2019
CarolEidt
left a comment
CarolEidt
left a comment
There was a problem hiding this comment.
LGTM other than the comparing of a bool to 0
added 2 commits
February 21, 2019 18:45
Author
|
@dotnet-bot test Windows_NT arm Cross Checked Innerloop Build and Test |
AndyAyersMS
reviewed
Feb 22, 2019
briansull
reviewed
Feb 22, 2019
Author
|
I believe this change is good to be merged |
jashook
pushed a commit
to jashook/coreclr
that referenced
this pull request
May 30, 2019
…dotnet#22775) * Set flag in comp info to signal that a caller has >8 byte struct args This will be used by fgCanFastTailCall to correctly determine whether an arm64 or x64 linux caller/callee can fastTailCall. It is also a workaround to #12468 to catch early any slot shuffling that would happen in LowerFastTailCall. Which currently assumes all parameters are one slot size. * Address feedback * Apply format patch * Add comment * apply new format patch
jashook
pushed a commit
that referenced
this pull request
Jun 4, 2019
* Set flag in comp info to signal that a caller has >8 byte struct args (#22775) * Set flag in comp info to signal that a caller has >8 byte struct args This will be used by fgCanFastTailCall to correctly determine whether an arm64 or x64 linux caller/callee can fastTailCall. It is also a workaround to #12468 to catch early any slot shuffling that would happen in LowerFastTailCall. Which currently assumes all parameters are one slot size. * Address feedback * Apply format patch * Add comment * apply new format patch * Address feedback and add header
jashook
pushed a commit
that referenced
this pull request
Jun 6, 2019
* Set flag in comp info to signal that a caller has >8 byte struct args (#22775) * Set flag in comp info to signal that a caller has >8 byte struct args This will be used by fgCanFastTailCall to correctly determine whether an arm64 or x64 linux caller/callee can fastTailCall. It is also a workaround to #12468 to catch early any slot shuffling that would happen in LowerFastTailCall. Which currently assumes all parameters are one slot size. * Address feedback * Apply format patch * Add comment * apply new format patch * Address feedback and add header
|
did this not ship with .net core 2.1.12? |
Member
|
This fix should be in 2.1.12 (and in 2.2.6), but doesn't seem to be called out in the release notes for either. @vivmishra can you check if #24858 (2.1) and #24954 (2.2) was included in the releases but overlooked in the notes? |
|
Those two PRs did not have correct label or milestone set. I have fixed that now and added CoreCLR to rel notes. Cc: @leecow ; @RussKeldorph |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…dotnet/coreclr#22775) * Set flag in comp info to signal that a caller has >8 byte struct args This will be used by fgCanFastTailCall to correctly determine whether an arm64 or x64 linux caller/callee can fastTailCall. It is also a workaround to dotnet/coreclr#12468 to catch early any slot shuffling that would happen in LowerFastTailCall. Which currently assumes all parameters are one slot size. * Address feedback * Apply format patch * Add comment * apply new format patch Commit migrated from dotnet/coreclr@0a29aaf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be used by fgCanFastTailCall to correctly determine whether an arm64
or x64 linux caller/callee can fastTailCall.
It is also a workaround to #12468 to catch early any slot shuffling that would happen in LowerFastTailCall. Which currently assumes all parameters are one slot size.
Fixes #22330.