This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix missing project error in official build#21767
Merged
sbomer merged 5 commits intodotnet:masterfrom Jan 7, 2019
Merged
Conversation
morganbr
approved these changes
Jan 2, 2019
echesakov
approved these changes
Jan 3, 2019
| publishing to blob feeds, but it requires a project file that | ||
| imports nuget restore targets to be specified for this to | ||
| work. See details in | ||
| https://github.com/dotnet/arcade/commit/f657be5cb7cd4920334dd9162173b131211a1e17#r31728598. |
Member
There was a problem hiding this comment.
Is there ever any reason this project will no longer be needed? That would be helpful if it would be easy for someone to determine it can be removed in the future.
Member
Author
There was a problem hiding this comment.
This should go away as part of the remaining arcade onboarding process since we'll always be building with a project file (if we are able to follow the recommended model - if not, we may want to ask the eng team to give us an option that allows us to restore without an empty project). dotnet/arcade#1633 provides a partial opt-out for the new behavior, but doesn't quite suffice for us.
sandreenko
pushed a commit
to sandreenko/coreclr
that referenced
this pull request
Jan 8, 2019
In response to dotnet/arcade#1567. This uses an empty project to work around the new behavior that requires a project file even for restore operations.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
In response to dotnet/arcade#1567. This uses an empty project to work around the new behavior that requires a project file even for restore operations. Commit migrated from dotnet/coreclr@c0d7784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since picking up dotnet/arcade#1567, our official builds have been broken because they use arcade to restore some tasks and sign in cases where we don't specify a project to build. From https://dnceng.visualstudio.com/internal/_build/results?buildId=64720:
The arcade change now requires a project to be specified, so empty.proj will serve this purpose until we set up an actual project as the arcade entry point.