This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Use EventSource guid ctor for RuntimeEventSource#21714
Merged
jkotas merged 1 commit intodotnet:masterfrom Dec 30, 2018
Merged
Conversation
Member
Author
|
@dotnet-bot test Windows_NT x64 Formatting |
Member
Author
|
@dotnet-bot test Ubuntu x64 Formatting |
jkotas
reviewed
Dec 30, 2018
src/System.Private.CoreLib/src/System/Diagnostics/Eventing/DotNETRuntimeEventSource.cs
Show resolved
Hide resolved
Member
|
Thanks @benaadams! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the GetGuid reflection path for it in startup
To
/cc @jkotas @vancem @brianrob
Contributes to https://github.com/dotnet/corefx/issues/34283#issuecomment-451015598