Win arm64 by rahku · Pull Request #2170 · dotnet/coreclr

rahku · 2015-11-26T00:51:39Z

Arm64 SDK is still to be released. Using a private drop of the toolset and these changes I am able to successfully build arm64 builds for windows. We need to set certain environment variables to override the location of toolset and sdk.

rahku · 2015-11-26T01:14:31Z

Please review.
@gkhanna79 @jkotas @janvorli @briansull

jkotas · 2015-11-26T02:20:12Z

Could you please rebase away the merge commits? Assuming you have a typical setup:

git rebase -i master
git push -f origin winArm64

rahku · 2015-11-26T03:01:33Z

done

manu-st · 2015-11-26T03:08:20Z

CMakeLists.txt

Should `cl.exe' be really hardcoded? Same goes for other binaries that got converted to a hardcoded name with .exe.

We should not hardcode the cl.exe. What is the problem with using the CMAKE_CXX_COMPILER?

kangaroo · 2015-11-26T03:45:56Z

Has this been checked to make sure it doesn't regress the arm64/linux build?
Additionally, can't CMAKE_TOOLCHAIN_FILE be used instead of all the hardcoded names?

janvorli · 2015-11-26T07:34:23Z

CMakeLists.txt

I know that this comment was there before, but it sounds weird. Could you please change it to "Enable edit and continue"? We don't need to enumerate the platforms, the surrounding ifs are descriptive enough.

rahku · 2015-11-26T15:55:05Z

Thanks for the review. I will try this again after I am back from my trip. closing for now. If anyone wants to use it ...can do so using winArm64 branch of my fork.

jashook · 2015-12-03T21:21:27Z

Reopening this pull request to start working on it some more.

I will have a change out to address comments soon.

jashook · 2015-12-04T01:19:57Z

Messed up with the commit. Hopefully did it as expected, didn't entirely know whether to modify the original commit or no. I can change that if instructed.

@jkotas @janvorli PTAL.

kangaroo · 2015-12-05T05:14:14Z

CMakeLists.txt

Is I386 really supported in CoreCLR currently? Otherwise we can unify these message()'s and drop the if()

It's supported in the sense that it builds successfully for x86 (or at least used to when I wrote that if).

Also we are working on x86 JIT bring up at the moment.

kangaroo · 2015-12-05T05:19:50Z

~~LGTM~~ modulo feedback, and @jkotas comments on the hard coded tools.

EDIT: No LGTM until the actual SDK is released for us proletariats.

jashook · 2015-12-08T02:10:57Z

Outdated comment.

@jkotas PTAL

gkhanna79 · 2015-12-08T05:26:39Z

@jashook PEr https://msdn.microsoft.com/en-us/library/9a89h429.aspx?f=255&MSPPError=-2147217396, you should not need SAFESEH as it is applicable to x86 only (as noted in the PR as well).

Can you please share the failure you are running into?

gkhanna79 · 2015-12-14T17:17:23Z

@jashook Can you please squash the commits?

@mmitche Are the OSX build failures the issues you were looking into last week?

mmitche · 2015-12-14T18:34:09Z

@gkhanna79 Yeah they are.

jashook · 2015-12-14T19:40:24Z

@gkhanna79 Squashed

jashook · 2015-12-15T01:59:14Z

@jkotas @gkhanna79 PTAL. Removed SafeSEH and verified that the build is still successful.

gkhanna79 · 2015-12-15T15:24:40Z

The x86 Windows Debug build failed due to the following:

18:30:15 Read in 1611 resources from "d:\j\workspace\dotnet_coreclr\x86_debug_windows_nt_prtest\src\mscorlib\src\mscorlib.txt"
18:30:15 Writing resource file... Done.
18:30:28 mscorlib -> d:\j\workspace\dotnet_coreclr\x86_debug_windows_nt_prtest\bin\obj\Windows_NT.x86.Debug\mscorlib.dll
18:31:03
18:31:03 Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
18:31:03 at Microsoft.Cci.ISymUnmanagedWriter2.Close()
18:31:03 at BclRewriter.Program.RunBclRewriter(String[] args)
18:31:03 at BclRewriter.Program.Main(String[] args)

@weshaggard @AlexGhiondea Are you aware of this issue?

gkhanna79 · 2015-12-15T15:25:43Z

@jashook Please sign the CLA. See https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/contributing.md#contributor-license-agreement for details.

gkhanna79 · 2015-12-15T15:31:01Z

LGTM. Please squash the commits, sign CLA and update this thread once done.

Successfully builds all binaries except sos.dll & x64 binaries

AlexGhiondea · 2015-12-15T18:22:09Z

@gkhanna79 no -- I have not seen that before. Does it repro consistently?

gkhanna79 · 2015-12-15T18:27:33Z

It looks occasional - you can see the history.

jashook · 2015-12-15T18:32:03Z

Squashed, it also looks like Rahul needs to sign the CLA as I have already done that. Closing this PR then opening a new one to point to this.

dnfclas added the cla-required label Nov 26, 2015

rahku force-pushed the winArm64 branch from 3a32e4e to 4c6dcb1 Compare November 26, 2015 03:00

manu-st reviewed Nov 26, 2015
View reviewed changes

janvorli reviewed Nov 26, 2015
View reviewed changes

rahku closed this Nov 26, 2015

jashook reopened this Dec 3, 2015

dnfclas added the cla-required label Dec 3, 2015

jashook force-pushed the winArm64 branch from 2b446f3 to 10c9f53 Compare December 4, 2015 00:06

jashook closed this Dec 4, 2015

jashook reopened this Dec 4, 2015

dnfclas added the cla-required label Dec 4, 2015

jashook closed this Dec 4, 2015

jashook reopened this Dec 4, 2015

dnfclas added the cla-required label Dec 4, 2015

jashook force-pushed the winArm64 branch from 10c9f53 to fd480d5 Compare December 4, 2015 01:18

jashook force-pushed the winArm64 branch 2 times, most recently from 02b9772 to a423f2e Compare December 5, 2015 00:45

jashook force-pushed the winArm64 branch 2 times, most recently from f2cd82b to bc9c031 Compare December 5, 2015 01:23

kangaroo reviewed Dec 5, 2015
View reviewed changes

mikedn mentioned this pull request Dec 5, 2015

Use /safeseh to compile x86 MASM files #2247

Merged

jashook force-pushed the winArm64 branch 2 times, most recently from 3c992ef to e269c4d Compare December 8, 2015 02:09

jashook force-pushed the winArm64 branch from e269c4d to c04f870 Compare December 10, 2015 17:57

jashook force-pushed the winArm64 branch from c04f870 to 1a6e660 Compare December 14, 2015 19:39

Build arm64 using private toolset

ab8261b

Successfully builds all binaries except sos.dll & x64 binaries

jashook force-pushed the winArm64 branch from f89c0bd to ab8261b Compare December 15, 2015 18:31

jashook closed this Dec 15, 2015

jashook mentioned this pull request Dec 15, 2015

Win arm64 #2344

Merged

rahku deleted the winArm64 branch January 4, 2016 20:01

Conversation

rahku commented Nov 26, 2015

Uh oh!

rahku commented Nov 26, 2015

Uh oh!

jkotas commented Nov 26, 2015

Uh oh!

rahku commented Nov 26, 2015

Uh oh!

manu-st Nov 26, 2015

Choose a reason for hiding this comment

Uh oh!

janvorli Nov 26, 2015

Choose a reason for hiding this comment

Uh oh!

kangaroo commented Nov 26, 2015

Uh oh!

janvorli Nov 26, 2015

Choose a reason for hiding this comment

Uh oh!

rahku commented Nov 26, 2015

Uh oh!

jashook commented Dec 3, 2015

Uh oh!

jashook commented Dec 4, 2015

Uh oh!

kangaroo Dec 5, 2015

Choose a reason for hiding this comment

Uh oh!

mikedn Dec 5, 2015

Choose a reason for hiding this comment

Uh oh!

jashook Dec 5, 2015

Choose a reason for hiding this comment

Uh oh!

kangaroo commented Dec 5, 2015

Uh oh!

jashook commented Dec 8, 2015

Uh oh!

gkhanna79 commented Dec 8, 2015

Uh oh!

gkhanna79 commented Dec 14, 2015

Uh oh!

mmitche commented Dec 14, 2015

Uh oh!

jashook commented Dec 14, 2015

Uh oh!

jashook commented Dec 15, 2015

Uh oh!

gkhanna79 commented Dec 15, 2015

Uh oh!

gkhanna79 commented Dec 15, 2015

Uh oh!

gkhanna79 commented Dec 15, 2015

Uh oh!

AlexGhiondea commented Dec 15, 2015

Uh oh!

gkhanna79 commented Dec 15, 2015

Uh oh!

jashook commented Dec 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants