Fix for PMI assert: 'vnWx != NoVN' #21512
Conversation
|
@sandreenko PTAL |
|
Can we validate this also fixes https://github.com/dotnet/coreclr/issues/21490? |
|
@tannergooding - How can I run this test leg on my changes using the CI?
|
|
test Windows_NT x64 Checked jitx86hwintrinsicnosimd |
|
@dotnet-bot Test Windows_NT x64 Checked jitx86hwintrinsicnosimd |
sandreenko
left a comment
sandreenko
left a comment
There was a problem hiding this comment.
Do you expect any asm diffs from that change?
src/jit/valuenum.cpp
Outdated
| switch (oper) | ||
| { | ||
| case GT_LCL_VAR: | ||
| case GT_REG_VAR: |
There was a problem hiding this comment.
It was deleted by
e1a5d0: Eliminate GenTreeRegVar and GT_REG_VAR and RegVar (#18317)
I may mistakenly be on a branch of a branch
There was a problem hiding this comment.
I rebased and pushed to origin to fix this
|
cc @dotnet/jit-contrib |
|
@dotnet-bot Test Windows_NT x64 Checked jitx86hwintrinsicnosimd |
|
@dotnet-bot test Windows_NT x64 Checked jitnox86hwintrinsic |
|
Also fixes #21231 |
Fix for PMI assert: 'vnWx != NoVN' Commit migrated from dotnet/coreclr@36df5c5
4 participants
This assert can fire when rhsVNPair is still set to NoVN, because we set isNewUniq to true and didn't set up rhsVNPair .
This fix reorders the check for isNewUniq, so that we avoid calling vnPairApplySelectorsAssign when we will assign the rhsVNPair to a new unique value number.
Fixes VSO 750014