This repository was archived by the owner on Jan 23, 2023. It is now read-only.
JIT: move indirect call transformations to a new source file #21414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up from a review comment in dotnet#21270.
Member
Author
|
@sandreenko PTAL No source code changes; a few minor comment edits. |
Member
Author
|
Perf test failures are known issues. Fix is #21412. |
CarolEidt
reviewed
Dec 6, 2018
CarolEidt
left a comment
CarolEidt
left a comment
There was a problem hiding this comment.
I have some comments on the comments. I realize it's all pre-existing, but I'd never reviewed this before.
| // The IndirectCallTransformer transforms indirect calls that involve fat pointers | ||
| // or guarded devirtualization candidates. | ||
| // | ||
| // A fat function pointer is pointer with the second least significant bit set, |
| // | ||
| // Jit is responsible for the checking the bit, do the regular call if it is not set | ||
| // or load hidden argument, fix the pointer and make a call with the fixed pointer and | ||
| // the instantiation argument. |
There was a problem hiding this comment.
It would be nice if the above paragraph was consistent with the use of imperative (fix the pointer) vs. present participle (checking the bit)
| // previous statements | ||
| // transforming statement | ||
| // { | ||
| // call with GTF_CALL_M_FAT_POINTER_CHECK flag set in function ptr |
There was a problem hiding this comment.
I think that this should say GTF_CALL_M_FAT_POINTER_CHECK flag set on the call node.
Member
Author
|
@CarolEidt I have another edit in progress up for this file, so will fix the issues you note above there. |
AndyAyersMS
added a commit
to AndyAyersMS/coreclr
that referenced
this pull request
Dec 6, 2018
Follow-up from dotnet#21270 and dotnet#21414. Block general cloning from inadvertently cloning a candidate call. Add a separate path for cloning calls that are inline and guarded devirtualization candidates for use by guarded devirtualization. Callers need to take extra steps after cloning one of these calls to properly fix everything up. Also fix up some issues in the large comment for the fat calli transformation.
AndyAyersMS
added a commit
that referenced
this pull request
Dec 7, 2018
Follow-up from #21270 and #21414. Block general cloning from inadvertently cloning a candidate call. Add a separate path for cloning calls that are inline and guarded devirtualization candidates for use by guarded devirtualization. Callers need to take extra steps after cloning one of these calls to properly fix everything up. Also fix up some issues in the large comment for the fat calli transformation.
morganbr
pushed a commit
that referenced
this pull request
Dec 14, 2018
Follow-up from #21270 and #21414. Block general cloning from inadvertently cloning a candidate call. Add a separate path for cloning calls that are inline and guarded devirtualization candidates for use by guarded devirtualization. Callers need to take extra steps after cloning one of these calls to properly fix everything up. Also fix up some issues in the large comment for the fat calli transformation.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…coreclr#21414) Follow-up from a review comment in dotnet/coreclr#21270. Commit migrated from dotnet/coreclr@6e9c14e
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Follow-up from dotnet/coreclr#21270 and dotnet/coreclr#21414. Block general cloning from inadvertently cloning a candidate call. Add a separate path for cloning calls that are inline and guarded devirtualization candidates for use by guarded devirtualization. Callers need to take extra steps after cloning one of these calls to properly fix everything up. Also fix up some issues in the large comment for the fat calli transformation. Commit migrated from dotnet/coreclr@08be98c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from a review comment in #21270.