Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Port #18267 fix value numbering when selecting a constant to release/2.2 #21228

Merged
AndyAyersMS merged 1 commit into from
Nov 28, 2018
Merged

Port #18267 fix value numbering when selecting a constant to release/2.2 #21228

AndyAyersMS merged 1 commit into from
Nov 28, 2018

Conversation

@AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented Nov 27, 2018

Master PR #18627

When applying selectors, constants were special-cased to not require any
type casts. However this is wrong if a narrowing needs to be performed.

Fix #18235

@AndyAyersMS
Port fix value numbering when selecting a constant to release/2.2
470d299 
Master PR dotnet#18627

When applying selectors, constants were special-cased to not require any
type casts. However this is wrong if a narrowing needs to be performed.

Fix #18235
@AndyAyersMS AndyAyersMS added this to the 2.2 milestone Nov 27, 2018
@vivmishra vivmishra modified the milestones: 2.2, 2.2.1 Nov 27, 2018
briansull
briansull approved these changes Nov 27, 2018
View reviewed changes
Copy link

@briansull briansull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Nov 28, 2018

CI got restarted...

@dotnet-bot test this please

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Nov 28, 2018

Formatter with the usual shutdown failure...

16:44:08 Shutting down VB/C# compiler server...
16:44:08 MSBuild server shut down successfully.
16:44:08 VB/C# compiler server shut down successfully.
16:44:08 Deleting D:\j\workspace\x64_windows_n---594a8999\jitutils
16:44:08 Deleting D:\j\workspace\x64_windows_n---594a8999\dj
16:44:08 Traceback (most recent call last):
16:44:08   File "tests\scripts\format.py", line 253, in <module>
16:44:08     return_code = main(sys.argv[1:])
16:44:08   File "tests\scripts\format.py", line 236, in main
16:44:08     shutil.rmtree(dotnetcliPath, onerror=del_rw)
16:44:08   File "C:\Python27\lib\shutil.py", line 252, in rmtree
16:44:08     onerror(os.remove, fullname, sys.exc_info())
16:44:08   File "tests\scripts\format.py", line 30, in del_rw
16:44:08     os.remove(name)
16:44:08 WindowsError: [Error 5] Access is denied: 'D:\\j\\workspace\\x64_windows_n---594a8999\\dj\\dotnet.exe'

@dotnet-bot retest Windows_NT x64 Formatting

OSX with networking failure

16:28:19  > git fetch --tags --progress https://github.com/dotnet/coreclr +refs/heads/*:refs/remotes/origin/* # timeout=90
16:32:21 FATAL: java.nio.channels.ClosedChannelException
16:32:21 java.nio.channels.ClosedChannelException
16:32:21 Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from 167.220.2.56/167.220.2.56:34253
16:32:21 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)

@dotnet-bot retest OSX10.12 x64 Checked Innerloop Build and Test

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Nov 28, 2018

OSX seems to be hung after running out of disk space:

17:37:31 /Users/dotnet-bot/j/workspace/dotnet_coreclr/release_2.2/x64_checked_osx10.12_innerloop_tst_prtest/Tools/dotnetcli/sdk/2.1.2/NuGet.targets(103,5): 
error : No space left on device

am going to restart.

@dotnet-bot retest OSX10.12 x64 Checked Innerloop Build and Test

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Nov 28, 2018

Am not going to wait for the ubuntu formatting....

@AndyAyersMS AndyAyersMS merged commit 8429614 into dotnet:release/2.2 Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@briansull briansull briansull approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen bug Product bug (most likely)

Projects

None yet

Milestone

2.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyAyersMS @briansull @vivmishra