This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Mark GCCollect test as GC stress excluded#17319
Merged
BruceForstall merged 1 commit intodotnet:masterfrom Mar 31, 2018
Merged
Conversation
This test is incompatible with GC stress. The tests compares results of GC.GetTotalMemory before and after GC.Collect and fails if the size before the collection is smaller than after the collection. But GC stress breaks this assumption.
BruceForstall
approved these changes
Mar 31, 2018
AndyAyersMS
added a commit
to AndyAyersMS/coreclr
that referenced
this pull request
Apr 3, 2018
Extends changes in dotnet#17319 to cover stress tests run via the normal msbuild/xunit test harness.
AndyAyersMS
added a commit
that referenced
this pull request
Apr 3, 2018
Extends changes in #17319 to cover stress tests run via the normal msbuild/xunit test harness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is incompatible with GC stress. The tests compares results of
GC.GetTotalMemory before and after GC.Collect and fails if the size
before the collection is smaller than after the collection. But GC
stress breaks this assumption.