Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix the code-size estimation for AVX/AVX2 ExtractVector128#17180

Merged
CarolEidt merged 1 commit intodotnet:masterfrom
fiigii:fixavxtests
Mar 31, 2018
Merged

Fix the code-size estimation for AVX/AVX2 ExtractVector128#17180
CarolEidt merged 1 commit intodotnet:masterfrom
fiigii:fixavxtests

Conversation

@fiigii
Copy link

@fiigii fiigii commented Mar 24, 2018

The code size of vextracti/f128 could be different based on the base register of the dst address.

The bug was detected by JITStress tests.

@CarolEidt @tannergooding

@fiigii fiigii changed the title Fix the code-size estamition for AVX/AVX2 ExtractVector128 Fix the code-size estimation for AVX/AVX2 ExtractVector128 Mar 24, 2018
fiigii
fiigii commented Mar 24, 2018
View reviewed changes
src/jit/hwintrinsicxarch.cpp Outdated
case InstructionSet_SSE41:
case InstructionSet_SSE42:
case InstructionSet_AVX:
case InstructionSet_AVX2:
Copy link
Author

@fiigii fiigii Mar 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move AVX/AVX2/SSE4.1 to fully-implemented ISA for GCStress/JITStress.

Copy link
Member

@tannergooding tannergooding Mar 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also being handled by #17184, the same comment I made there applies here

Copy link
Author

@fiigii fiigii Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will remove here after #17184 gets merged.

@fiigii fiigii mentioned this pull request Mar 24, 2018
Merged
@fiigii
Copy link
Author

fiigii commented Mar 27, 2018

test Windows_NT x86 Checked gcstress0xc_jitstress1
test Windows_NT x86 Checked gcstress0xc_jitstress2
test Windows_NT x64 Checked gcstress0xc_jitstress1
test Windows_NT x64 Checked gcstress0xc_jitstress2
test Ubuntu x64 Checked gcstress0xc_jitstress1
test Ubuntu x64 Checked gcstress0xc_jitstress2

test Windows_NT x64 Checked jitstressregs4
test Windows_NT x86 Checked jitstressregs4

CarolEidt
CarolEidt approved these changes Mar 27, 2018
View reviewed changes
Copy link

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fiigii
Copy link
Author

fiigii commented Mar 28, 2018

test Windows_NT x64 Checked gcstress0xc_jitstress1
test Windows_NT x64 Checked gcstress0xc_jitstress2

@fiigii
Copy link
Author

fiigii commented Mar 30, 2018 •
edited
Loading

x86 gcstress failures will be fixed by #17314, and other failures are not related to this change. Let’s merge this PR.

@fiigii
Copy link
Author

fiigii commented Mar 30, 2018

@CarolEidt ping?

@fiigii fiigii mentioned this pull request Mar 31, 2018
Merged
@CarolEidt CarolEidt merged commit c9ddfbf into dotnet:master Mar 31, 2018
@fiigii fiigii deleted the fixavxtests branch March 31, 2018 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@tannergooding tannergooding tannergooding left review comments

@CarolEidt CarolEidt CarolEidt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fiigii @CarolEidt @tannergooding @FeiPengIntel