Adding support for more AVX hardware intrinsics#16655
Adding support for more AVX hardware intrinsics#16655tannergooding merged 2 commits intodotnet:masterfrom tannergooding:hwintrin-avx
Conversation
CarolEidt
left a comment
CarolEidt
left a comment
There was a problem hiding this comment.
LGTM overall, though I did not scrutinize the test generator changes.
src/jit/hwintrinsicxarch.cpp
Outdated
| } | ||
| } | ||
|
|
||
| if (!varTypeIsSIMD(retType) || (flags & HW_Flag_BaseTypeFromArg)) |
There was a problem hiding this comment.
This should be:
if (!varTypeIsSIMD(retType) || ((flags & HW_Flag_BaseTypeFromArg) != 0))
|
Rebased to resolve merge conflicts |
|
test Windows_NT x64 Checked jitincompletehwintrinsic test Windows_NT x86 Checked jitincompletehwintrinsic test Ubuntu x64 Checked jitincompletehwintrinsic test OSX10.12 x64 Checked jitincompletehwintrinsic |
2 participants
FYI. @fiigii, @CarolEidt, @eerhardt, @RussKeldorph